Skip to content

fix: detect resource deletion in cmmn engine duplicate deployment filter #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omkasera972-ai wants to merge 4 commits into
base: main
Choose a base branch
from
+29 −0
Open

fix: detect resource deletion in cmmn engine duplicate deployment filter #4330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88eb96b
fix: detect resource deletion in duplicate deployment filter
omkasera972-ai Nov 7, 2026
242797c
fix: detect resource deletion in app engine duplicate deployment filter
omkasera972-ai Nov 7, 2026
84df733
fix: detect resource deletion in cmmn engine duplicate deployment filter
omkasera972-ai Nov 7, 2026
b1269f8
fix: detect resource deletion in cmmn engine duplicate deployment fil…
omkasera972-ai Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions modules/flowable-app-engine/src/main/java/org/flowable/app/engine/impl/cmd/DeployCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,16 @@ protected boolean deploymentsDiffer(AppDeploymentEntity deployment, AppDeploymen
Map<String, EngineResource> resources = deployment.getResources();
Map<String, EngineResource> savedResources = saved.getResources();

// Check if any non-generated resource was removed in the new deployment
for (String savedResourceName : savedResources.keySet()) {
EngineResource savedResource = savedResources.get(savedResourceName);
if (savedResource != null && !savedResource.isGenerated()) {
if (!resources.containsKey(savedResourceName)) {
return true;
}
}
}

for (String resourceName : resources.keySet()) {
EngineResource savedResource = savedResources.get(resourceName);

Expand Down
9 changes: 9 additions & 0 deletions modules/flowable-cmmn-engine/src/main/java/org/flowable/cmmn/engine/impl/cmd/DeployCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,15 @@ protected boolean deploymentsDiffer(CmmnDeploymentEntity deployment, CmmnDeploym
Map<String, EngineResource> resources = deployment.getResources();
Map<String, EngineResource> savedResources = saved.getResources();

// Check if any non-generated resource was removed in the new deployment (Modern Java Functional Stream)
boolean hasRemovedResource = savedResources.entrySet().stream()
.filter(entry -> entry.getValue() != null && !entry.getValue().isGenerated())
.anyMatch(entry -> !resources.containsKey(entry.getKey()));

if (hasRemovedResource) {
return true;
}

for (String resourceName : resources.keySet()) {
EngineResource savedResource = savedResources.get(resourceName);

Expand Down
10 changes: 10 additions & 0 deletions modules/flowable-engine/src/main/java/org/flowable/engine/impl/cmd/DeployCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,16 @@ protected boolean deploymentsDiffer(DeploymentEntity deployment, DeploymentEntit
Map<String, EngineResource> resources = deployment.getResources();
Map<String, EngineResource> savedResources = saved.getResources();

// Check if any non-generated resource was removed in the new deployment
for (String savedResourceName : savedResources.keySet()) {
EngineResource savedResource = savedResources.get(savedResourceName);
if (savedResource != null && !savedResource.isGenerated()) {
if (!resources.containsKey(savedResourceName)) {
return true;
}
}
}

for (String resourceName : resources.keySet()) {
EngineResource savedResource = savedResources.get(resourceName);

Expand Down