Repository navigation
fix: detect resource deletion in app engine duplicate deployment filter - #4329
Open
omkasera972-ai wants to merge 2 commits into
Open
omkasera972-ai wants to merge 2 commits into
omkasera972-ai wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a logic bug in the app engine duplicate deployment filter (
deploymentsDiffermethod insideDeployCmdinflowable-app-engine).Previously, when checking if a new app deployment differed from an existing saved deployment, the code only checked resources present in the new deployment. If a user deleted a non-generated resource while keeping the remaining resources identical, the duplicate filter failed to detect the deletion and returned
false. This caused the app engine to skip creating the new deployment.Changes
deploymentsDifferinmodules/flowable-app-engine/src/main/java/org/flowable/app/engine/impl/cmd/DeployCmd.javato check if any non-generated resource insavedResourceswas removed in the new deployment.truewhen a resource deletion is detected so that a new deployment is properly created.Checklist
🤖 Generated with Claude Code