#1390 - configurable backend for group by buckets#2473
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2473 +/- ##
==========================================
Coverage 86.36% 86.36%
- Complexity 22901 22958 +57
==========================================
Files 1740 1748 +8
Lines 70386 70535 +149
==========================================
+ Hits 60789 60918 +129
- Misses 9597 9617 +20 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
norberttech
reviewed
Jun 22, 2026
norberttech
reviewed
Jun 22, 2026
norberttech
reviewed
Jun 22, 2026
norberttech
reviewed
Jun 22, 2026
norberttech
reviewed
Jun 22, 2026
norberttech
reviewed
Jul 7, 2026
norberttech
reviewed
Jul 7, 2026
norberttech
reviewed
Jul 7, 2026
c81915c to
83bf6e7
Compare
norberttech
reviewed
Jul 11, 2026
norberttech
reviewed
Jul 11, 2026
ef4fd15 to
6d769f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes GroupBy aggregation memory-efficient and configurable (issue #1390): keep the fast in-memory path by default, or opt into an external, bounded-memory path.
Resolves: #1390
Resolves: #2472 because this pr resolve this problem.
Change Log
Added
ConfigBuilder::aggregationAlgorithm()and theAggregationAlgorithmsenum select betweenMEMORY_AGGREGATION(default, in-memory hash map) andEXTERNAL_AGGREGATION(sorts by the group-by columns and folds, spilling to disk for bounded memory), withaggregationFilesystem()for the spill protocol.Rows.Fixed
Changed
Removed
Deprecated
Security