Binding: rename Worker to Go - #48
Merged
Merged
Conversation
Binding.Worker becomes Binding.Go, after errgroup.Group.Go and sync.WaitGroup.Go, whose contract it has always had: run a function in a goroutine the group tracks, cancel it when the group winds down, wait for it, and let its error take the group down. No alias is left behind, so an upgrade breaks a caller that registers a worker, by exactly one rename; the CHANGELOG says so and the release is 0.16.0. The word "worker" still names what the method registers, in the docs, the guide in all four languages, and the one error Stop reports about it, which now reads "worker did not return" rather than "Worker hook did not return". Nothing about the machinery changes: the binding field, the phase handoff and releaseAfterWorker are as they were. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding.WorkerbecomesBinding.Go, aftererrgroup.Group.Goandsync.WaitGroup.Go, whose contract it has always had: run a function in a goroutine the group tracks, cancel it when the group winds down, wait for it, and let its error take the group down. The chain now readsBreaking: no alias is left behind, so a caller on
Workerrenames the call toGoand nothing else changes.go doc -allagainst v0.15.1 removesBinding.Workerand addsBinding.Gowith the same signature;dihttpanddislogare unchanged. The CHANGELOG says so, for 0.16.0.The word "worker" still names what the method registers: in the README, DESIGN.md, CLAUDE.md, the guide in all four languages, and the one error
Stopreports about it, now "worker did not return". The machinery is untouched; this is a rename of one method, its docs, 13 call sites in tests and examples, and the prose.Verified: the full gate (gofmt, vet, race suite, golangci-lint, embedmd), the examples module, and the site's check and build.
🤖 Generated with Claude Code