Declare moved_from for renamed immutable inputs - #81
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Declare moved_from for renamed immutable inputs#81devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: brandon <brandon@flightcontrol.dev>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Ravion Module Publish PlanDry run only. No Ravion API mutations were made.
Diffsrvn-acm-certificate 0.4.0 -> 0.4.1--- remote
+++ compiled
id: domains
immutable: true
label: Domains
+ moved_from:
+ - domain_name
+ - subject_alternative_names
placeholder: api.example.com
required: true
type: string_array
@@
- [AWS Certificate Manager DNS validation](https://docs.aws.amazon.com/acm/latest/userguide/dns-validation.html)
- [AWS Certificate Manager certificates for CloudFront](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/cnames-and-https-requirements.html)
- - [Source module](https://github.com/flightcontrolhq/modules/tree/rvn-acm-certificate@0.4.0/security/acm_certificate)
+ - [Source module](https://github.com/flightcontrolhq/modules/tree/rvn-acm-certificate@0.4.1/security/acm_certificate)
stack:
pipelines:
change:
@@
base_path: security/acm_certificate
branch: main
execution_environment_id: << module.input.execution_environment_id >>
- ref: rvn-acm-certificate@0.4.0
+ ref: rvn-acm-certificate@0.4.1
repo: https://github.com/flightcontrolhq/modules
stack_id: <<stack.id>>
terraform_variables:rvn-ecs-nlb 0.3.1 -> 0.3.2--- remote
+++ compiled
item_title:
template: "{listener_protocol} {listener_port}"
label: Listeners
+ moved_from:
+ - listener_port
+ - listener_protocol
+ - container_port
+ - tls_certificate
+ - tls_ssl_policy
+ - tls_alpn_policy
+ - tls_target_protocol
required: true
type: object_array
- add_button_label: Add CIDR block
@@
The module is intentionally focused on Layer 4 services behind a Network Load Balancer. Use ECS Web Service for HTTP host and path routing through an Application Load Balancer.
- Terraform source: [flightcontrolhq/modules/compute/ecs_service](https://github.com/flightcontrolhq/modules/tree/rvn-ecs-nlb@0.3.1/compute/ecs_service)
+ Terraform source: [flightcontrolhq/modules/compute/ecs_service](https://github.com/flightcontrolhq/modules/tree/rvn-ecs-nlb@0.3.2/compute/ecs_service)
## Use cases
@@
base_path: compute/ecs_service
branch: main
execution_environment_id: << module.input.execution_environment_id >>
- ref: rvn-ecs-nlb@0.3.1
+ ref: rvn-ecs-nlb@0.3.2
repo: https://github.com/flightcontrolhq/modules
stack_id: <<stack.id>>
terraform_variables: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENG-5084: module versions that renamed or merged immutable inputs currently can't be upgraded to —
IMMUTABLE_INPUT_CHANGEDfires even when the resolved Terraform is a no-op. The platform side adds a declarativemoved_fromlist (flightcontrolhq/flightcontrol#6750); this declares it on the two definitions that hit the problem.rvn-acm-certificate0.4.1 —domains←domain_name,subject_alternative_names(the 0.4.0 breaking change from the ticket).rvn-ecs-nlb0.3.2 —listeners← the former flat single-listener inputs (listener_port,listener_protocol,container_portandtls_target_protocolwere immutable; thetls_*ones are listed too since they moved into the same object array).Both are patch bumps: no Terraform or input behavior changes, only metadata that lets existing instances upgrade in place instead of being destroyed and recreated (new certificate ARN, ALB listener repoint, fresh DNS validation).
I scanned the definition history for other cross-version immutable input renames; the rest of the hits were same-version dev churn or
$includepartial extractions, not published renames.module-schema.jsongets the field too, though it's already noted as a stale snapshot of the Flightcontrol schema.Verified with
ravion-modules validate/compileand the tools test suite.make publish-local-devcould not run here — it requires the local dev API atlocalhost:8080.Link to Devin session: https://app.devin.ai/sessions/ccb6dfc1435b4b6ea8002216c7ec2f66
Requested by: @flybayer
Greptile Summary
Adds metadata enabling upgrades across renamed immutable inputs.
listenersinput and releases version 0.3.2.domainsand releases version 0.4.1.moved_fromto the input variants represented by the repository’s schema snapshot.Confidence Score: 5/5
The PR appears safe to merge with no concrete changed-code failure identified.
The predecessor IDs match the historical renamed inputs, and the metadata-only patch releases do not alter Terraform behavior or current input mappings.
Important Files Changed
listenersand bumps the patch release.domainsand bumps the patch release.moved_fromon the input variants represented by this stale schema snapshot.Reviews (1): Last reviewed commit: "Declare moved_from for renamed immutable..." | Re-trigger Greptile