fix(build): handle read-only files on Windows in rmtree to prevent PermissionError (fixes #6808) - #6817
Open
eminsk wants to merge 1 commit into
Open
fix(build): handle read-only files on Windows in rmtree to prevent PermissionError (fixes #6808)#6817eminsk wants to merge 1 commit into
eminsk wants to merge 1 commit into
Conversation
…rmissionError (fixes flet-dev#6808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR fixes
PermissionError: [WinError 5] Access deniedon Windows duringflet build windowswhen cleaning up output directories that contain read-only files (such as.gitpack/index objects).Fixes #6808
Root Cause
In
flet_cli/commands/build_base.py:On Windows, standard
shutil.rmtreewithout an error handler fails withPermissionErrorwhen encountering files with the read-only attribute (stat.S_IREAD), which frequently occur inside.git/objects/pack/or other build artifacts.Solution
rmtreetoflet.utils.files(and re-exported inflet.utils) with an error handler that removes the read-only attribute (os.chmod(path, stat.S_IWRITE)) before retrying deletion. Supports both Python 3.12+ (onexc) and prior versions (onerror).build_base.pyto usermtreeinstead of directshutil.rmtreefor directory cleanup.sdk/python/packages/flet/tests/test_files.py.Summary by Sourcery
Make Windows build directory cleanup resilient to read-only files.
Bug Fixes:
Enhancements:
Tests: