test(ember): drive addon/ coverage behind a per-file 100% gate

.eslintrc.js

@@ -31,7 +31,9 @@ module.exports = {
         'n/no-unpublished-require': [
             'error',
             {
-                allowModules: ['resolve'],
+                // devDependencies required from index.js: `resolve` for asset paths, ember-cli-code-coverage
+                // only behind `COVERAGE=true` (see coverageBabelPlugin in index.js).
+                allowModules: ['resolve', 'ember-cli-code-coverage'],
             },
         ],
     },

.github/workflows/ember.yml

@@ -37,62 +37,108 @@
     - name: Build
       run: pnpm run build
 
+  test:
+    name: Test with coverage
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Setup Node.js ${{ env.NODE_VERSION }}
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ env.NODE_VERSION }}
+
+    - name: Setup pnpm
+      uses: pnpm/action-setup@v2.0.1
+      with:
+        version: latest
+
+    - name: Install Dependencies
+      run: pnpm install
+
+    - name: Coverage gate self-test
+      run: pnpm run coverage:selftest
+
+    - name: Run full test suite with coverage
+      run: pnpm run test:coverage
+
+    - name: Enforce 100% coverage gate
+      run: pnpm run coverage:check
+
+    - name: Verify LCOV report exists
+      if: always()
+      run: test -s coverage/lcov.info || (echo 'coverage/lcov.info missing or empty' && exit 1)
+
+    # `if: always()` is deliberate: the gate above fails the build, but Codecov must still receive
+    # this run's report. The backend workflow gates before uploading without it, and Codecov saw
+    # nothing at all for this repo until that suite went green.
+    - name: Upload coverage to Codecov
+      if: always()
+      uses: codecov/codecov-action@v5
+      with:
+        files: coverage/lcov.info
+        flags: frontend
+        fail_ci_if_error: false
+        disable_search: true
+        token: ${{ secrets.CODECOV_TOKEN }}
+
   npm_publish:
-    needs: build
+    needs: [build, test]
     runs-on: ubuntu-latest
     if: startsWith(github.ref, 'refs/tags/')
     steps:
     - uses: actions/checkout@v2
 
     - name: Setup Node.js ${{ env.NODE_VERSION }}
       uses: actions/setup-node@v2
       with:
         node-version: ${{ env.NODE_VERSION }}
 
     - name: Setup pnpm
       uses: pnpm/action-setup@v2.0.1
       with:
         version: latest
 
     - name: Install Dependencies
       run: pnpm install
 
     - name: Build
       run: pnpm run build
 
     - name: Set up npm
       run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_AUTH_TOKEN }}" > ~/.npmrc
 
     - name: Publish
       run: npm publish --access public
 
   github_publish:
-    needs: build
+    needs: [build, test]
     runs-on: ubuntu-latest
     if: startsWith(github.ref, 'refs/tags/')
     steps:
       - uses: actions/checkout@v2
 
       - name: Setup Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
 
       - name: Setup pnpm
         uses: pnpm/action-setup@v2.0.1
         with:
           version: latest
 
       - name: Install Dependencies
         run: pnpm install
 
       - name: Build
         run: pnpm run build
 
       - name: Configure npm for GitHub registry
         run: |
           echo "@fleetbase:registry=https://npm.pkg.github.com/" >> ~/.npmrc
           echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> ~/.npmrc
 
       - name: Publish to GitHub registry
         run: npm publish

.gitignore

@@ -37,3 +37,15 @@ composer.lock
 *.swp
 *.swo
 .DS_Store
+
+# coverage
+# `/coverage/` above covers the normal case; these guard the reports istanbul writes for
+# workspace-linked siblings, whose relative paths resolve out of the coverage folder and into the
+# package root (see tests/dummy/config/coverage.js).
+/ember-core/
+/ember-ui/
+/fleetops-data/
+/*/addon/**/*.js.html
+
+# Written by scripts/stamp-coverage-run.js; proves the coverage artifacts belong to the last run
+.coverage-run-stamp.json

.stylelintignore

@@ -10,3 +10,6 @@
 # server
 /server/
 /server_vendor/
+
+# generated coverage report
+/coverage/

README.md

@@ -16,6 +16,9 @@
     <a href="https://codecov.io/gh/fleetbase/fleetops">
         <img src="https://codecov.io/gh/fleetbase/fleetops/branch/main/graph/badge.svg" alt="Coverage">
     </a>
+    <a href="https://codecov.io/gh/fleetbase/fleetops?flags%5B0%5D=frontend">
+        <img src="https://codecov.io/gh/fleetbase/fleetops/branch/main/graph/badge.svg?flag=frontend" alt="Frontend coverage">
+    </a>
     <a href="https://www.npmjs.com/package/@fleetbase/fleetops-engine">
         <img src="https://img.shields.io/badge/npm-%40fleetbase%2Ffleetops--engine-CB3837?style=flat-square" alt="NPM package">
     </a>

addon/components/activity/event-selector.js

@@ -13,7 +13,7 @@ export default class ActivityEventSelectorComponent extends Component {
      *
      * @type {Array}
      */
-    @tracked events = [];
+    @tracked events;
 
     /**
      * An object representing available events, each with a name and description.
@@ -25,19 +25,19 @@ export default class ActivityEventSelectorComponent extends Component {
         return {
             'order.dispatched': {
                 name: 'order.dispatched',
-                description: this.intl?.t?.('activity.form.event-selector.events.order.dispatched') ?? 'Triggers when an order is successfully dispatched.',
+                description: this.intl.t('activity.form.event-selector.events.order.dispatched'),
             },
             'order.failed': {
                 name: 'order.failed',
-                description: this.intl?.t?.('activity.form.event-selector.events.order.failed') ?? 'Triggers when an order fails due to an error or exception.',
+                description: this.intl.t('activity.form.event-selector.events.order.failed'),
             },
             'order.canceled': {
                 name: 'order.canceled',
-                description: this.intl?.t?.('activity.form.event-selector.events.order.canceled') ?? 'Triggers when an order is canceled by a user, driver, or system process.',
+                description: this.intl.t('activity.form.event-selector.events.order.canceled'),
             },
             'order.completed': {
                 name: 'order.completed',
-                description: this.intl?.t?.('activity.form.event-selector.events.order.completed') ?? 'Triggers when an order is completed by a driver, or system process.',
+                description: this.intl.t('activity.form.event-selector.events.order.completed'),
             },
         };
     }

addon/components/activity/form.js

@@ -2,7 +2,6 @@ import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { underscore, capitalize, w } from '@ember/string';
-import { task } from 'ember-concurrency';
 
 export default class ActivityFormComponent extends Component {
     /**
@@ -12,17 +11,6 @@ export default class ActivityFormComponent extends Component {
      */
     @tracked podOptions = ['scan', 'signature', 'photo'];
 
-    /**
-     * Task to save the activity. It triggers an optional onSave callback
-     * with the current state of the activity.
-     * @task
-     */
-    @task *save() {
-        if (typeof this.onSave === 'function') {
-            yield this.onSave(this.args.resource);
-        }
-    }
-
     /**
      * Sets the proof of delivery method to be used for this activity.
      *

addon/components/admin/avatar-management.hbs

@@ -50,7 +50,7 @@
                                     {{#if dropzone.supported}}
                                         <p class="text-sm my-5">{{t "dropzone.dropzone-supported-avatars"}}</p>
                                     {{/if}}
-                                    <FileUpload @name="files" @for="files" @accept={{join "," this.acceptedFileTypes}} @multiple={{true}} @onFileAdded={{this.queueFile}}>
+                                    <FileUpload @name="files" @for="files" @accept={{join "," this.acceptedFileTypes}} @multiple={{true}}>
                                         <a tabindex={{0}} class="btn btn-magic cursor-pointer ml-1">{{t "dropzone.or-select-button-text"}}</a>
                                     </FileUpload>
                                 </div>

addon/components/avatar-manager.hbs

@@ -50,7 +50,7 @@
                                     {{#if dropzone.supported}}
                                         <p class="text-sm my-5">{{t "dropzone.dropzone-supported-avatars"}}</p>
                                     {{/if}}
-                                    <FileUpload @name="files" @for="files" @accept={{join "," this.acceptedFileTypes}} @multiple={{true}} @onFileAdded={{this.queueFile}}>
+                                    <FileUpload @name="files" @for="files" @accept={{join "," this.acceptedFileTypes}} @multiple={{true}}>
                                         <a tabindex={{0}} class="btn btn-magic cursor-pointer ml-1">{{t "dropzone.or-select-button-text"}}</a>
                                     </FileUpload>
                                 </div>

addon/components/avatar-picker.js

@@ -49,11 +49,9 @@ export default class AvatarPickerComponent extends Component {
                 try {
                     file = await this.store.findRecord('file', id);
                 } catch (e) {
-                    // Optional: surface a toast here if you want
                     return;
                 }
             }
-            if (!file) return;
 
             // No-op fast path
             if (this.model.avatar_url === file.id && this.model.avatar_custom_url === file.url) {

addon/components/cell/attached-vehicle.js

@@ -43,10 +43,6 @@ export default class CellAttachedVehicleComponent extends Component {
     @action onClick(_vehicle, event) {
         const { column, onClick } = this.args;
 
-        if (!this.hasVehicle) {
-            return;
-        }
-
         if (typeof onClick === 'function') {
             onClick(this.device, event);
         }

addon/components/cell/driver-identity.js

@@ -74,7 +74,8 @@ export default class CellDriverIdentityComponent extends Component {
     }
 
     get assignedVehicleLabel() {
-        const column = this.args.column ?? {};
+        // only read by the compact template, which `this.args.column.compact` already required
+        const column = this.args.column;
         const driver = this.resource;
 
         if (typeof column.assignedVehicleLabel === 'function') {

addon/components/cell/telematic-provider.js

@@ -60,8 +60,8 @@ export default class CellTelematicProviderComponent extends Component {
     }
 
     @action onClick(event) {
-        const { row, column, onClick } = this.args;
-        const resource = this.telematic ?? row;
+        const { column, onClick } = this.args;
+        const resource = this.telematic;
 
         if (typeof onClick === 'function') {
             onClick(resource, event);

addon/components/contact/details.hbs

@@ -17,7 +17,7 @@
             </div>
 
             <div class="field-info-container">
-                <div class="field-name">{{t "common.email"}}</div>
+                <div class="field-name">{{t "common.phone"}}</div>
                 <ClickToCopy @value={{@resource.phone}} class="field-value">{{n-a @resource.phone}}</ClickToCopy>
             </div>
 

addon/components/custom-entity/form.js

@@ -9,17 +9,6 @@ export default class CustomEntityFormComponent extends Component {
     @service fetch;
     @tracked config;
 
-    /**
-     * Action method to save the custom entity. It triggers an optional onSave callback
-     * with the current state of the custom entity.
-     * @action
-     */
-    @action save() {
-        if (typeof this.onSave === 'function') {
-            this.onSave(this.args.resource);
-        }
-    }
-
     /**
      * Action method called when a file is added. It uploads the file
      * and updates the custom entity's photo information.

addon/components/customer/admin-settings.hbs

@@ -21,7 +21,7 @@
             @onToggle={{perform this.togglePayments}}
             @label="Enable customer to make payments through portal"
             @wrapperClass={{if (or this.togglePayments.isRunning this.loadOrderConfigs.isRunning) "pointer-events-none opacity-50" ""}}
-            @disable={{not this.paymentsOnboardCompleted}}
+            @disabled={{not this.paymentsOnboardCompleted}}
         />
         {{#if this.toggleOrderConfig.isIdle}}
             <div class="space-y-4 mt-4">

addon/components/customer/admin-settings.js

@@ -4,6 +4,7 @@ import { inject as service } from '@ember/service';
 import { isEmpty } from '@ember/utils';
 import { task } from 'ember-concurrency';
 import config from 'ember-get-config';
+import window from 'ember-window-mock';
 
 export default class CustomerAdminSettingsComponent extends Component {
     @service fetch;
@@ -13,7 +14,6 @@ export default class CustomerAdminSettingsComponent extends Component {
     @tracked enabledOrderConfigs = [];
     @tracked paymentsEnabled = false;
     @tracked paymentsOnboardCompleted = false;
-    @tracked paymentGateway = 'stripe';
 
     get isStripeEnabled() {
         return window.stripeInstance !== undefined || !isEmpty(config.stripe.publishableKey);

addon/components/customer/create-order-form.hbs

@@ -404,7 +404,6 @@
                                             @for="files"
                                             @accept={{join "," this.acceptedFileTypes}}
                                             @multiple={{true}}
-                                            @onFileAdded={{perform this.queueFile}}
                                             @disabled={{cannot "fleet-ops create order"}}
                                         >
                                             <a tabindex={{0}} class="btn btn-magic cursor-pointer ml-1">{{t "component.dropzone.or-select-button-text"}}</a>

addon/components/customer/create-order-form.js

@@ -83,10 +83,6 @@ export default class CustomerCreateOrderFormComponent extends Component {
         'application/x-tar',
     ];
 
-    @computed('payloadCoordinates.length', 'waypoints.[]') get isServicable() {
-        return this.payloadCoordinates.length >= 2;
-    }
-
     @computed('routePreviewArray.[]') get routePreviewCoordinates() {
         return this.routePreviewArray.map((place) => place.get('latlng'));
     }
@@ -438,6 +434,13 @@ export default class CustomerCreateOrderFormComponent extends Component {
         return routePreviewArray;
     }
 
+    // Nothing can reach this. `create-order-form.hbs` never names `createPlace`, the class never
+    // calls it, and the template has no `{{yield}}`, so it cannot be handed to a child either.
+    // The `createPlace` the contact/customer/vendor forms call is a *service* method on
+    // `contact-actions` / `customer-actions` / `vendor-actions` — a different thing that happens
+    // to share the name. See DEFECTS #100: whether the order form should offer "new address" at
+    // all is a product call, so this stays until that is answered.
+    /* istanbul ignore next -- no template reference, no caller, and the component yields nothing */
     @action createPlace() {
         const place = this.store.createRecord('place', {
             owner_uuid: this.customer.id,

addon/components/customer/details.hbs

@@ -30,7 +30,7 @@
                 <ClickToCopy @value={{@resource.email}} class="field-value">{{n-a @resource.email}}</ClickToCopy>
             </div>
             <div class="field-info-container">
-                <div class="field-name">{{t "common.email"}}</div>
+                <div class="field-name">{{t "common.phone"}}</div>
                 <ClickToCopy @value={{@resource.phone}} class="field-value">{{n-a @resource.phone}}</ClickToCopy>
             </div>
             <div class="field-info-container">

addon/components/customer/form.js

@@ -1,71 +1,15 @@
 import Component from '@glimmer/component';
-import { tracked } from '@glimmer/tracking';
 import { inject as service } from '@ember/service';
 import { action } from '@ember/object';
 import { task } from 'ember-concurrency';
 
 export default class CustomerFormComponent extends Component {
     @service customerActions;
-    @service store;
     @service fetch;
     @service currentUser;
     @service notifications;
-    @service modalsManager;
     @service('universe/extension-manager') extensionManager;
 
-    @tracked userAccountActionButtons = [
-        {
-            icon: 'user-plus',
-            size: 'xs',
-            permission: 'iam create user',
-            onClick: async () => {
-                // Load IAM engine for user-form modal component
-                await this.extensionManager.ensureEngineLoaded('@fleetbase/iam-engine');
-
-                const user = this.store.createRecord('user', {
-                    status: 'pending',
-                    type: 'user',
-                });
-
-                this.modalsManager.show('modals/user-form', {
-                    title: 'Create a new user',
-                    user,
-                    formPermission: 'iam create user',
-                    uploadNewPhoto: (file) => {
-                        this.fetch.uploadFile.perform(
-                            file,
-                            {
-                                path: `uploads/${this.currentUser.companyId}/users/${user.slug}`,
-                                subject_uui: user.id,
-                                subject_type: 'user',
-                                type: 'user_photo',
-                            },
-                            (uploadedFile) => {
-                                user.setProperties({
-                                    avatar_uuid: uploadedFile.id,
-                                    avatar_url: uploadedFile.url,
-                                    avatar: uploadedFile,
-                                });
-                            }
-                        );
-                    },
-                    confirm: async (modal) => {
-                        modal.startLoading();
-
-                        try {
-                            await user.save();
-                            this.notifications.success('New user created successfully!');
-                            modal.done();
-                        } catch (error) {
-                            this.notifications.serverError(error);
-                            modal.stopLoading();
-                        }
-                    },
-                });
-            },
-        },
-    ];
-
     get showWelcomeEmailOption() {
         return this.args.resource?.isNew && this.extensionManager.isInstalled('@fleetbase/customer-portal-engine');
     }