Repository navigation
Conversation
Add deployment security review controls with separate permissions for approval and evidence access. Incomplete collection remains visible as unknown coverage.
Code Review SummaryThe deployment security tab now embeds a security reviews panel showing profile status, coverage gaps, findings, run history and approval of exact revisions, gated by new granular permissions. Users with security_profiles:read can open the tab, while the legacy protected-path and rate-limit editors stay behind security read permission. The nginx listen port is now configurable via MANAGEMENT_LISTEN. 🚀 Key Improvements
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| }); | ||
| if (!error.value) await refresh(); | ||
| } | ||
| async function loadEvidence(id: string) { |
There was a problem hiding this comment.
When the evidence request fails, the previously loaded evidence stays rendered under the newly selected finding, so the report shows evidence belonging to a different signal while only an error hints at the failure. Clear it before requesting.
Suggested change
| async function loadEvidence(id: string) { | |
| async function loadEvidence(id: string) { | |
| if (!selectedReport.value) return; | |
| evidence.value = null; | |
| await action(async () => { | |
| evidence.value = (await securityReviewsApi.evidence(props.name, selectedReport.value!.id, id)).data.evidence; | |
| }); | |
| } |
Clear earlier evidence before loading another selection. Late responses cannot populate a different report.
Deploying flatrun-ui with
|
| Latest commit: |
b79b059
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://836adf76.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-security-module.flatrun-ui.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deployment security review controls with separate permissions for approval and evidence access. Incomplete collection remains visible as unknown coverage.