Repository navigation
Run site builds on GitHub's runners only - #50
Merged
Merged
Conversation
The repository variable RUNNER could send the deploy and preview jobs to a self-hosted runner on a personal computer. This repository is public, so its jobs now always run on GitHub's own runners: runs-on is fixed, and the steps that existed only for the self-hosted runner are gone. Gems are cached by setup-ruby as before on hosted runners.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Both workflows (
deploy.yml,preview.yml) now always run onubuntu-latest. The repository variableRUNNERis no longer read, and the steps that existed only for the self-hosted runner (its own gem installation) are removed. On hosted runnersruby/setup-rubyinstalls Ruby 3.3 and caches the gems, as it did before the self-hosted option was added in #20.Why
This repository is public. A job from a public repository should never run on a personal computer: the only barrier between a pull request from a fork and that computer is the approval to run its workflow.
After merging
RUNNER(Settings → Secrets and variables → Actions → Variables).Validation
runs-onisubuntu-latestand the step lists are unchanged apart from the removed self-hosted step.