Skip to content

[RTDB Desktop] Fix use-after-free in WebSocketListenResponse by removing dangling View* pointer #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AustinBenoit merged 4 commits into from
Jul 28, 2026
Merged

[RTDB Desktop] Fix use-after-free in WebSocketListenResponse by removing dangling View* pointer #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00b0f30
Fix issue in WebSocketListenResponse by removing View* pointer
AustinBenoit Jul 27, 2026
7c40a2e
add release notes
AustinBenoit Jul 27, 2026
1a9992d
fix formatting
AustinBenoit Jul 27, 2026
d0fd639
Merge branch 'main' into fix-rtdb-view-uaf
AustinBenoit Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions database/src/desktop/core/info_listen_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@
#include "database/src/desktop/core/listen_provider.h"
#include "database/src/desktop/core/tag.h"
#include "database/src/desktop/util_desktop.h"
#include "database/src/desktop/view/view.h"

namespace firebase {
namespace database {
namespace internal {

void InfoListenProvider::StartListening(const QuerySpec& query_spec,
const Tag& tag, const View* view) {
const Tag& tag) {
repo_->scheduler().Schedule([this, query_spec]() {
const Variant& value = VariantGetChild(info_data_, query_spec.path);
if (!VariantIsEmpty(value)) {
Expand Down
3 changes: 1 addition & 2 deletions database/src/desktop/core/info_listen_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ class InfoListenProvider : public ListenProvider {

void set_sync_tree(SyncTree* sync_tree) { sync_tree_ = sync_tree; }

void StartListening(const QuerySpec& query_spec, const Tag& tag,
const View* view) override;
void StartListening(const QuerySpec& query_spec, const Tag& tag) override;

void StopListening(const QuerySpec& query_spec, const Tag& tag) override;

Expand Down
4 changes: 1 addition & 3 deletions database/src/desktop/core/listen_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#include "database/src/common/query_spec.h"
#include "database/src/desktop/core/tag.h"
#include "database/src/desktop/view/view.h"

namespace firebase {
namespace database {
Expand All @@ -32,8 +31,7 @@ class ListenProvider {
// Begin listening on a location with a set of parameters given by the
// QuerySpec. While listening, the server will send down updates which will be
// parsed and passed along to the SyncTree to be cached locally.
virtual void StartListening(const QuerySpec& query_spec, const Tag& tag,
const View* view) = 0;
virtual void StartListening(const QuerySpec& query_spec, const Tag& tag) = 0;

// Stop listening on a location given by the QuerySpec.
virtual void StopListening(const QuerySpec& query_spec, const Tag& tag) = 0;
Expand Down
10 changes: 4 additions & 6 deletions database/src/desktop/core/sync_tree.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,7 @@ std::vector<Event> SyncTree::AddEventRegistration(
writes_cache, server_cache,
persistence_manager_.get());
if (!view_already_exists && !found_ancestor_default_view) {
const View* view = sync_point->ViewForQuery(query_spec);
SetupListener(query_spec, view);
SetupListener(query_spec);
}
return true;
});
Expand Down Expand Up @@ -547,11 +546,10 @@ static QuerySpec QuerySpecForListening(const QuerySpec& query_spec) {
}
}

void SyncTree::SetupListener(const QuerySpec& query_spec, const View* view) {
void SyncTree::SetupListener(const QuerySpec& query_spec) {
const Path& path = query_spec.path;
const Tag& tag = TagForQuerySpec(query_spec);
listen_provider_->StartListening(QuerySpecForListening(query_spec), tag,
view);
listen_provider_->StartListening(QuerySpecForListening(query_spec), tag);

Tree<SyncPoint>* subtree = sync_point_tree_.GetChild(path);

Expand Down Expand Up @@ -663,7 +661,7 @@ std::vector<Event> SyncTree::RemoveEventRegistration(
for (const View* view : new_views) {
QuerySpec new_query = view->query_spec();
listen_provider_->StartListening(QuerySpecForListening(new_query),
TagForQuerySpec(new_query), view);
TagForQuerySpec(new_query));
}
} else {
// There's nothing below us, so nothing we need to start listening on
Expand Down
2 changes: 1 addition & 1 deletion database/src/desktop/core/sync_tree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class SyncTree {
private:
// For a given new listen, manage the de-duplication of outstanding
// subscriptions.
void SetupListener(const QuerySpec& query_spec, const View* view);
void SetupListener(const QuerySpec& query_spec);

// Recursive helper for ApplyOperationToSyncPoints
std::vector<Event> ApplyOperationHelper(const Operation& operation,
Expand Down
12 changes: 4 additions & 8 deletions database/src/desktop/core/web_socket_listen_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "database/src/desktop/connection/persistent_connection.h"
#include "database/src/desktop/core/listen_provider.h"
#include "database/src/desktop/core/tag.h"
#include "database/src/desktop/view/view.h"

namespace firebase {
namespace database {
Expand All @@ -34,33 +33,30 @@ class WebSocketListenResponse : public connection::Response {
WebSocketListenResponse(const Response::ResponseCallback& callback,
const Repo::ThisRef& repo_ref, SyncTree* sync_tree,
const QuerySpec& query_spec, const Tag& tag,
const View* view, Logger* logger)
Logger* logger)
: connection::Response(callback),
repo_ref_(repo_ref),
sync_tree_(sync_tree),
query_spec_(query_spec),
tag_(tag),
view_(view),
logger_(logger) {}

Repo::ThisRef& repo_ref() { return repo_ref_; }
SyncTree* sync_tree() { return sync_tree_; }
const QuerySpec& query_spec() const { return query_spec_; }
const Tag& tag() const { return tag_; }
const View* view() const { return view_; }
Logger* logger() { return logger_; }

private:
Repo::ThisRef repo_ref_;
SyncTree* sync_tree_;
QuerySpec query_spec_;
Tag tag_;
const View* view_;
Logger* logger_;
};

void WebSocketListenProvider::StartListening(const QuerySpec& query_spec,
const Tag& tag, const View* view) {
const Tag& tag) {
connection_->Listen(
query_spec, tag,
std::make_shared<WebSocketListenResponse>(
Expand All @@ -79,7 +75,7 @@ void WebSocketListenProvider::StartListening(const QuerySpec& query_spec,

std::vector<Event> events;

@github-actions github-actions Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Lint warning: Add #include <vector> for vector<>

if (!response->HasError()) {
const QuerySpec& query_spec = response->view()->query_spec();
const QuerySpec& query_spec = response->query_spec();
const Tag& tag = response->tag();
if (tag.has_value()) {
events = response->sync_tree()->ApplyTaggedListenComplete(tag);
Expand All @@ -101,7 +97,7 @@ void WebSocketListenProvider::StartListening(const QuerySpec& query_spec,
}
repo->PostEvents(events);
},
repo_->this_ref(), sync_tree_, query_spec, tag, view, logger_));
repo_->this_ref(), sync_tree_, query_spec, tag, logger_));
}

void WebSocketListenProvider::StopListening(const QuerySpec& query_spec,
Expand Down
3 changes: 1 addition & 2 deletions database/src/desktop/core/web_socket_listen_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ class WebSocketListenProvider : public ListenProvider {

void set_sync_tree(SyncTree* sync_tree) { sync_tree_ = sync_tree; }

void StartListening(const QuerySpec& query_spec, const Tag& tag,
const View* view) override;
void StartListening(const QuerySpec& query_spec, const Tag& tag) override;

void StopListening(const QuerySpec& query_spec, const Tag& tag) override;

Expand Down
3 changes: 1 addition & 2 deletions database/tests/desktop/core/sync_point_spec_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ class FakeListenProvider : public ListenProvider {

~FakeListenProvider() override {}

void StartListening(const QuerySpec& query_spec, const Tag& tag,
const View* view) override {
void StartListening(const QuerySpec& query_spec, const Tag& tag) override {
const Path& path = query_spec.path;
logger_->LogDebug(
"Listening at %s for Tag %s", path.c_str(),
Expand Down
3 changes: 1 addition & 2 deletions database/tests/desktop/test/mock_listen_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ namespace internal {
class MockListenProvider : public ListenProvider {
public:
MOCK_METHOD(void, StartListening,
(const QuerySpec& query_spec, const Tag& tag, const View* view),
(override));
(const QuerySpec& query_spec, const Tag& tag), (override));
MOCK_METHOD(void, StopListening,
(const QuerySpec& query_spec, const Tag& tag), (override));
};
Expand Down
4 changes: 4 additions & 0 deletions release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,10 @@ workflow use only during the development of your app, not for publicly shipping
code.

## Release Notes
### Upcoming
- Changes
- Realtime Database (Desktop): Fixed an intermittent use-after-free crash (`ACCESS_VIOLATION`) when detaching a listener while a WebSocket listen response is pending.

### 13.10.0
- Changes
- General (Android): Update to Firebase Android BoM version 34.16.0.
Expand Down
Loading