feat(firestore-bigquery-export): add the sync queue params - #3129
Open
cabljac wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new configuration parameters to the Firestore BigQuery Export extension: MAX_DISPATCHES_PER_SECOND and MAX_ENQUEUE_ATTEMPTS, along with corresponding tests and helper functions to handle their defaults. The review comments correctly point out that the validation regexes for both parameters do not allow empty strings, which would cause deployment-time validation failures if left blank. Modifying these regexes to allow empty values is recommended.
cabljac
force-pushed
the
feat/kits-fbe-sync-queue-params
branch
from
September 7, 2026 16:45
713ed1d to
bcc01ef
Compare
cabljac
marked this pull request as ready for review
September 7, 2026 16:50
cabljac
force-pushed
the
feat/kits-fbe-sync-queue-params
branch
from
September 7, 2026 16:52
bcc01ef to
b3438b6
Compare
Adds MAX_DISPATCHES_PER_SECOND and MAX_ENQUEUE_ATTEMPTS with the extension's defaults of 100 and 3 and its validation ranges, plus the matching ExportConfig fields. IntParam.value() never consults the declared default, so unset and blank values are reported as undefined and the default applies in resolveExportConfig; an explicit 0 is preserved. Nothing reads the new fields yet.
cabljac
force-pushed
the
feat/kits-fbe-sync-queue-params
branch
from
September 7, 2026 17:26
b3438b6 to
d9f7bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third layer of the Cloud Tasks write buffer stack. Adds
MAX_DISPATCHES_PER_SECONDandMAX_ENQUEUE_ATTEMPTSwith the extension's defaults of 100 and 3 and its validation ranges, exposes the first as a config expression for the queue's rate limit, and adds the matching optionalExportConfigfields with defaults applied inresolveExportConfig. Nothing reads the new fields yet.One subtlety worth a look:
IntParam.value()isparseInt(env || "0", 10) || 0and never consults the declared default, so an unset param would reachresolveExportConfigas 0 and defeat the?? 100and?? 3fallbacks.optionalIntreports unset and blank env vars asundefinedand passes an explicit 0 through as a real setting. The test mock fordefineIntmirrors the real behaviour so the tests would catch a regression.81 tests pass.
Part of #3031.