fix(auth): mitigate tapjacking on the auth activity window#2416
Open
just1and0 wants to merge 1 commit into
Open
fix(auth): mitigate tapjacking on the auth activity window#2416just1and0 wants to merge 1 commit into
just1and0 wants to merge 1 commit into
Conversation
Fixes #2041 by ignoring touches when the auth UI window is obscured by another overlay, as recommended for overlay-based clickjacking attacks.
There was a problem hiding this comment.
Code Review
This pull request updates FirebaseAuthActivity by setting window.decorView.filterTouchesWhenObscured to true in onCreate. This is a security improvement to prevent tapjacking by filtering touch events when the window is obscured. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.decorView.filterTouchesWhenObscured = trueinFirebaseAuthActivity.onCreate()to mitigate tapjacking/clickjacking attacks where an overlay intercepts user touches on the auth UI.FirebaseAuthActivityis the only activity in the auth module (v10 is Compose-based), so this single-line change covers the entire auth flow.Fixes #2041
Test plan