Repository navigation
[ONB-4351] [Compose] [Compose] Add account certificates to v2 accounts and account numbers - #53
Merged
Merged
Conversation
Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Contributor
Author
|
fin review |
![fin-review[bot]](https://avatars.githubusercontent.com/u/62265373?s=60&v=4){kind=small}
Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Contributor
Author
|
fin review |
FranciscaOtero
marked this pull request as ready for review
November 12, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
The public API now returns an account certificate (a signed download URL for the account's PDF certificate) via
GET /v2/accounts/{id}/certificateandGET /v2/account_numbers/{id}/certificate(fintoc-com/fintoc-rails#20588). The SDK had no way to call them.¿Qué hay de nuevo?
client.v2.accounts.certificate(account_id)andclient.v2.account_numbers.certificate(account_number_id)Account#certificateandAccountNumber#certificateshortcutsFintoc::V2::AccountCertificateresource (account_id,account_number_id,download_url,expires_at)Tests
Release notes
client.v2.accounts.certificateandclient.v2.account_numbers.certificate(plusAccount#certificateandAccountNumber#certificate), which return a newFintoc::V2::AccountCertificatewith a signeddownload_urland itsexpires_at.Safety Checks
Consideraciones
Reviewed against
openapi_spec/main-api.jsonin fintoc-rails (9f54fc2b..7c92ffab); pacioli'score-api.jsondidn't change. Left out:/v2/crossborder/*operation is markedx-hiddenuntil GA, so not exposed yet.PATCH /v1/organizations/{id}and organizations without JWS (#20103, #20327): already shipped.limit_exceededon webhook endpoints (#20758):LimitExceededErroralready exists; the internal-host 400 (#20998) uses the generic error handling.split[].inheritedon v2 invoices,mx_direct_debit.error_reason(#20380, #20601, #20009): nested hashes, returned as-is.invoice.split_redirectedevent (#20443): the SDK doesn't validate event types.ui_mode: fieldsandpayment_method_options.card.bins(#20837, #20751), Chile onboardingplaft.cmf_*(#20814): passed through**params.Rollback
Safe to revert; only adds new methods.
🤖🐙 Created with Compose · View session