Skip to content

[ONB-4298] [Compose] [Compose] Add LimitExceededError for webhook endpoints - #51

Merged
fin-compose[bot] merged 1 commit into
mainfrom
compose/webhook-limit-exceeded-2205
Nov 11, 2026
Merged

fin-compose[bot] merged 1 commit into
mainfrom
compose/webhook-limit-exceeded-2205

Conversation

@FranciscaOtero

Copy link
Copy Markdown
Contributor

Contexto

The public API now caps active webhook endpoints at 16 per organization and mode. When the cap is hit, POST /v1/webhook_endpoints and PATCH /v1/webhook_endpoints/{id} respond 422 limit_exceeded (fintoc-com/fintoc-rails#20758). The SDK had no class for that code, so it surfaced as a generic FintocError.

¿Qué hay de nuevo?

  • Fintoc::Errors::LimitExceededError, raised when the API responds limit_exceeded

Tests

  • Unit tests for error resolution

Release notes

  • Added Fintoc::Errors::LimitExceededError, raised when creating or updating a webhook endpoint exceeds the active endpoint limit.

Safety Checks

  • Versión y CHANGELOG actualizados (si corresponde)

Consideraciones

Reviewed against openapi_spec/main-api.json in fintoc-rails (abddda4a..e297b6da); pacioli's core-api.json didn't change. Everything else in that range already matched the SDK, so it's left out of this PR:

  • Organizations create/update without JWS (fintoc-com/fintoc-rails#19988, #20074, #20044, #20103, #20327): already shipped.
  • split params on v2 invoices and v1/v2 payment intents, split/split_applied on payment intents v2 (#20107, #20108): passed through **params and already exposed as attributes. invoice_not_editable (409) already exists.
  • Split redirection fields, invoice_v2.split[].inherited, mx_direct_debit.error_reason (#20380, #20601, #20009): nested hashes, returned as-is.
  • invoice.split_redirected event (#20443): the SDK doesn't validate event types.
  • payment_method_options.card.bins on checkout sessions (#20751): passed through **params.

🤖🐙 Created with Compose · View session

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
@FranciscaOtero FranciscaOtero added the agent:compose PR created by Compose AI agent label Nov 11, 2026
@FranciscaOtero FranciscaOtero self-assigned this Nov 11, 2026
@fin-hermes fin-hermes Bot added the size/XS label Nov 11, 2026
@FranciscaOtero

Copy link
Copy Markdown
Contributor Author

fin review

@fin-hermes fin-hermes Bot added the risk:low label Nov 11, 2026
@FranciscaOtero FranciscaOtero added the release:minor Publica una versión minor al mergear label Nov 11, 2026

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@FranciscaOtero
FranciscaOtero marked this pull request as ready for review November 11, 2026 12:05

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@fin-compose
fin-compose Bot merged commit 1ab8e8c into main Nov 11, 2026
9 checks passed
@fin-compose
fin-compose Bot deleted the compose/webhook-limit-exceeded-2205 branch November 11, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:compose PR created by Compose AI agent release:minor Publica una versión minor al mergear risk:low size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant