Repository navigation
[ONB-4352] [Compose] [Compose] Add CMF onboarding flags and ui_mode fields - #66
Merged
Merged
Conversation
Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Collaborator
Author
|
fin review |
FranciscaOtero
marked this pull request as ready for review
November 12, 2026 12:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
I checked the public API changes in
openapi_spec/main-api.jsonfrom fintoc-rails (9f54fc2b→7c92ffab,/v1and/v2withoutinternal; pacioli'score-api.jsondid not change). Almost everything already matches the CLI or needs a fintoc-node release first. Two gaps:POST /v2/entities/{entity_id}/onboardings(Chile) now takesdata.plaft.cmf_regulatedanddata.plaft.cmf_registration_number(fintoc-com/fintoc-rails#20814), with no flags in the CLI.POST /v2/checkout_sessionsui_modenow acceptsfields(fintoc-com/fintoc-rails#20837), but--ui-modehelp only listedembedded.Release notes
v2 onboardings create: new--plaft-cmf-regulatedand--plaft-cmf-registration-numberflags to say whether the company is regulated by Chile's Financial Market Commission (CMF) and send its registration number.v2 checkout_sessions create:--ui-modehelp now listsfields.Que hay de nuevo?
fintoc v2 onboardings create --plaft-cmf-regulated true --plaft-cmf-registration-number 123→data.plaft.cmf_regulated,data.plaft.cmf_registration_number--ui-modehelp:(embedded, fields)Tests
Consideraciones
Left out or already matching:
PATCH /v1/organizations/{id}(fintoc-com/fintoc-rails#20103): left out, fintoc-node 1.31.0 (latest) has none of them. They need an SDK release first./v1/organizations(fintoc-com/fintoc-rails#20327):needsJwsstays onorganizations create, since--jws-private-keyis already published and removing it breaks compatibility; the API ignores the signature.--card-binsonv2 checkout_sessions create(fintoc-com/fintoc-rails#20751) already exists.split_applied[].redirected*,split[].inherited,mx_direct_debit.error_reason) show up ingetand--jsonwith no change (fintoc-com/fintoc-rails#20380, fintoc-com/fintoc-rails#20601, fintoc-com/fintoc-rails#20009).invoice.split_redirected(fintoc-com/fintoc-rails#20443):--enabled-events,webhook_endpoints test --typeand the events--typefilter take any value.--plaft-cmf-regulatedis not required: the spec requires it insideplaft, butplaftitself is optional and--plaft-uaf-obligatedisn't required either.🤖🐙 Created with Compose · View session