Skip to content

[ONB-4299] [Compose] [Compose] Add --card-bins to v2 checkout_sessions create - #65

Merged
fin-compose[bot] merged 1 commit into
mainfrom
compose/checkout-card-bins-eedb
Nov 11, 2026
Merged

fin-compose[bot] merged 1 commit into
mainfrom
compose/checkout-card-bins-eedb

Conversation

@FranciscaOtero

Copy link
Copy Markdown
Collaborator

Contexto

I checked the public API changes in openapi_spec/main-api.json from fintoc-rails (main abddda4a → e297b6da, /v1 and /v2 without internal; pacioli's core-api.json did not change). Almost everything already matches the CLI. The only gap: POST /v2/checkout_sessions now accepts payment_method_options.card.bins (fintoc-com/fintoc-rails#20751), and the CLI had no flag for it.

Release notes

  • v2 checkout_sessions create: new --card-bins flag to restrict the session to cards with the given BINs (6 or 8 digits each).

Que hay de nuevo?

  • fintoc v2 checkout_sessions create --card-bins 457173,45717360 → payment_method_options.card.bins

Tests

  • Unit tests (nested path of --card-bins), lint, typecheck, build.

Consideraciones

Already matching or left out:

  • POST /v1/organizations (fintoc-com/fintoc-rails#19988, fintoc-com/fintoc-rails#20074, fintoc-com/fintoc-rails#20044) is already organizations create; products.business_accounts goes through --products <json>.
  • PATCH /v1/organizations/{id} (fintoc-com/fintoc-rails#20103) is left out: fintoc-node 1.31.0 (latest) only has create for organizations.
  • JWS removal on /v1/organizations (fintoc-com/fintoc-rails#20327): needsJws stays, since --jws-private-key is already published and removing it breaks compatibility; the API ignores the signature.
  • split on POST/PATCH /v2/invoices and POST /v1|v2/payment_intents (fintoc-com/fintoc-rails#20107, fintoc-com/fintoc-rails#20108) is an array of objects, so it goes through --from-json, like lines. No flag added.
  • New response fields (split, split_applied, redirected*, inherited, mx_direct_debit.error_reason) show up in get and --json with no change (fintoc-com/fintoc-rails#20108, fintoc-com/fintoc-rails#20380, fintoc-com/fintoc-rails#20601, fintoc-com/fintoc-rails#20009).
  • invoice.split_redirected (fintoc-com/fintoc-rails#20443): --enabled-events, webhook_endpoints test --type and the events --type filter take any value.
  • New 409/422 responses (invoices PATCH, webhook endpoints limit of 16, fintoc-com/fintoc-rails#20758) surface through the existing API error output.
  • fintoc-com/fintoc-rails#20751 also adds bins to POST /v1/checkout_sessions, but the public spec only documents it in v2, so I only added it there.

🤖🐙 Created with Compose · View session

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
@FranciscaOtero FranciscaOtero added the agent:compose PR created by Compose AI agent label Nov 11, 2026
@FranciscaOtero FranciscaOtero self-assigned this Nov 11, 2026
@fin-hermes fin-hermes Bot added the size/XS label Nov 11, 2026
@FranciscaOtero FranciscaOtero added the release:minor Publica una versión minor al mergear label Nov 11, 2026
@fin-hermes fin-hermes Bot added the risk:low label Nov 11, 2026
@FranciscaOtero

Copy link
Copy Markdown
Collaborator Author

fin review

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@FranciscaOtero
FranciscaOtero marked this pull request as ready for review November 11, 2026 12:07

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@fin-compose
fin-compose Bot merged commit bbf2bb1 into main Nov 11, 2026
7 checks passed
@fin-compose
fin-compose Bot deleted the compose/checkout-card-bins-eedb branch November 11, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:compose PR created by Compose AI agent release:minor Publica una versión minor al mergear risk:low size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant