Repository navigation
[ONB-4299] [Compose] [Compose] Add --card-bins to v2 checkout_sessions create - #65
Merged
Merged
Conversation
Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Collaborator
Author
|
fin review |
FranciscaOtero
marked this pull request as ready for review
November 11, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
I checked the public API changes in
openapi_spec/main-api.jsonfrom fintoc-rails (mainabddda4a→e297b6da,/v1and/v2withoutinternal; pacioli'score-api.jsondid not change). Almost everything already matches the CLI. The only gap:POST /v2/checkout_sessionsnow acceptspayment_method_options.card.bins(fintoc-com/fintoc-rails#20751), and the CLI had no flag for it.Release notes
v2 checkout_sessions create: new--card-binsflag to restrict the session to cards with the given BINs (6 or 8 digits each).Que hay de nuevo?
fintoc v2 checkout_sessions create --card-bins 457173,45717360→payment_method_options.card.binsTests
--card-bins), lint, typecheck, build.Consideraciones
Already matching or left out:
POST /v1/organizations(fintoc-com/fintoc-rails#19988, fintoc-com/fintoc-rails#20074, fintoc-com/fintoc-rails#20044) is alreadyorganizations create;products.business_accountsgoes through--products <json>.PATCH /v1/organizations/{id}(fintoc-com/fintoc-rails#20103) is left out: fintoc-node 1.31.0 (latest) only hascreatefor organizations./v1/organizations(fintoc-com/fintoc-rails#20327):needsJwsstays, since--jws-private-keyis already published and removing it breaks compatibility; the API ignores the signature.splitonPOST/PATCH /v2/invoicesandPOST /v1|v2/payment_intents(fintoc-com/fintoc-rails#20107, fintoc-com/fintoc-rails#20108) is an array of objects, so it goes through--from-json, likelines. No flag added.split,split_applied,redirected*,inherited,mx_direct_debit.error_reason) show up ingetand--jsonwith no change (fintoc-com/fintoc-rails#20108, fintoc-com/fintoc-rails#20380, fintoc-com/fintoc-rails#20601, fintoc-com/fintoc-rails#20009).invoice.split_redirected(fintoc-com/fintoc-rails#20443):--enabled-events,webhook_endpoints test --typeand the events--typefilter take any value.PATCH, webhook endpoints limit of 16, fintoc-com/fintoc-rails#20758) surface through the existing API error output.binstoPOST /v1/checkout_sessions, but the public spec only documents it in v2, so I only added it there.🤖🐙 Created with Compose · View session