make help: list typecheck in the check description - #17
Conversation
There was a problem hiding this comment.
Verified against the target this line documents. Makefile:220 is:
check: format-check lint check-types typecheckso the old help text was missing typecheck and the new text now lists all four prerequisites in the same order the target declares them. typecheck already had its own entry in the Code Quality block, so this closes the last piece of the FL-10 drift. Column alignment and the padding before the dash are untouched.
I also cross-checked every make <target> mentioned in the help block against the real targets: no other stale or missing entries. The test-<name> and test-matrix-<name> lines are backed by the test-% and test-matrix-% pattern rules at Makefile:23 and Makefile:28.
CI is red, and it is not this diff. The Check job failed at the Install stylua step:
request to https://api.github.com/repos/JohnnyMorganz/stylua/releases failed,
reason: self-signed certificate
That is JohnnyMorganz/stylua-action@v4 failing to reach the releases API to download the binary, before any repo code runs. A @echo string in a help target cannot influence it. Supporting evidence: main was green at 22:03Z, about 90 minutes before this run, and this is the only failure in the last twelve runs. Reads like a transient runner or egress issue rather than a pinned-version problem.
A re-run should clear it. I tried, but the app token has no actions: write, so that one is yours.
Non-blocking, and outside FL-10's scope: all at Makefile:9 is format lint test build, so it is neither documented in help nor a superset of check, since it skips check-types and typecheck. Same category of drift FL-10 is cleaning up, if you want a follow-up ticket.
Approving on content. Worth confirming Check goes green on a re-run before merging, since it is a required check and the merge is currently blocked on it.
Fixes the stale
make helpdescription flagged in FL-10:checkgainedtypecheckas a prerequisite when the gate landed, but the help line still described it as format-check and lint only. One-line @echo edit, no behaviour change.Ref: https://youtrack.dmiller.me/issue/FL-10