Skip to content

make help: list typecheck in the check description - #17

Merged
derek-miller merged 1 commit into
mainfrom
fl-10-help-typecheck
Aug 12, 2026
Merged

make help: list typecheck in the check description#17
derek-miller merged 1 commit into
mainfrom
fl-10-help-typecheck

Conversation

@derek-miller

Copy link
Copy Markdown
Contributor

Fixes the stale make help description flagged in FL-10: check gained typecheck as a prerequisite when the gate landed, but the help line still described it as format-check and lint only. One-line @echo edit, no behaviour change.

Ref: https://youtrack.dmiller.me/issue/FL-10

@svc-finitelabs svc-finitelabs Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the target this line documents. Makefile:220 is:

check: format-check lint check-types typecheck

so the old help text was missing typecheck and the new text now lists all four prerequisites in the same order the target declares them. typecheck already had its own entry in the Code Quality block, so this closes the last piece of the FL-10 drift. Column alignment and the padding before the dash are untouched.

I also cross-checked every make <target> mentioned in the help block against the real targets: no other stale or missing entries. The test-<name> and test-matrix-<name> lines are backed by the test-% and test-matrix-% pattern rules at Makefile:23 and Makefile:28.

CI is red, and it is not this diff. The Check job failed at the Install stylua step:

request to https://api.github.com/repos/JohnnyMorganz/stylua/releases failed,
reason: self-signed certificate

That is JohnnyMorganz/stylua-action@v4 failing to reach the releases API to download the binary, before any repo code runs. A @echo string in a help target cannot influence it. Supporting evidence: main was green at 22:03Z, about 90 minutes before this run, and this is the only failure in the last twelve runs. Reads like a transient runner or egress issue rather than a pinned-version problem.

A re-run should clear it. I tried, but the app token has no actions: write, so that one is yours.

Non-blocking, and outside FL-10's scope: all at Makefile:9 is format lint test build, so it is neither documented in help nor a superset of check, since it skips check-types and typecheck. Same category of drift FL-10 is cleaning up, if you want a follow-up ticket.

Approving on content. Worth confirming Check goes green on a re-run before merging, since it is a required check and the merge is currently blocked on it.

@derek-miller
derek-miller merged commit 23257e5 into main Aug 12, 2026
10 of 11 checks passed
@derek-miller
derek-miller deleted the fl-10-help-typecheck branch August 12, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant