Skip to content

docs: drop stale CLAUDE.md claim that make help omits typecheck - #10

Merged
derek-miller merged 1 commit into
mainfrom
fl-14-claude-md-typecheck
Aug 12, 2026
Merged

docs: drop stale CLAUDE.md claim that make help omits typecheck#10
derek-miller merged 1 commit into
mainfrom
fl-14-claude-md-typecheck

Conversation

@derek-miller

Copy link
Copy Markdown
Contributor

Fixes FL-14: FL-10 corrected make help in all five repos, but two CLAUDE.md files still assert make help is stale about check omitting typecheck. make help now prints "Run format-check, lint, and typecheck", so the sentence is false. Scoped to deleting that one trailing sentence; the rest of the paragraph (make all is not a substitute for check) is still correct and untouched. Docs only.

Ref: https://youtrack.dmiller.me/issue/FL-14

@svc-finitelabs svc-finitelabs Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Verified against the tree at head, not just the PR description:

  • Makefile:217 prints make check - Run format-check, lint, and typecheck, so the sentence this PR deletes was false.
  • Makefile:188 is check: format-check lint typecheck and Makefile:9 is all: format lint test build, so the retained sentence ("make all is not a substitute for check") is still accurate and correctly left alone.
  • Diff is exactly that one sentence, nothing else.

Check is green at 75d3dd1. The Lua version matrix and the lua-openssl jobs were still in flight at review time; docs-only change, so nothing there gates this.

Grepped CLAUDE.md on main across every finitelabs lua-* repo: only this repo and lua-bthome-ble carry the sentence, and lua-bthome-ble#12 is the matching PR. Those two merges close FL-14 with no leftovers.

@derek-miller
derek-miller merged commit bd65527 into main Aug 12, 2026
11 checks passed
@derek-miller
derek-miller deleted the fl-14-claude-md-typecheck branch August 12, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant