docs: drop stale CLAUDE.md claim that make help omits typecheck - #10
Merged
Conversation
Contributor
There was a problem hiding this comment.
Approved. Verified against the tree at head, not just the PR description:
Makefile:217printsmake check - Run format-check, lint, and typecheck, so the sentence this PR deletes was false.Makefile:188ischeck: format-check lint typecheckandMakefile:9isall: format lint test build, so the retained sentence ("make allis not a substitute forcheck") is still accurate and correctly left alone.- Diff is exactly that one sentence, nothing else.
Check is green at 75d3dd1. The Lua version matrix and the lua-openssl jobs were still in flight at review time; docs-only change, so nothing there gates this.
Grepped CLAUDE.md on main across every finitelabs lua-* repo: only this repo and lua-bthome-ble carry the sentence, and lua-bthome-ble#12 is the matching PR. Those two merges close FL-14 with no leftovers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FL-14: FL-10 corrected
make helpin all five repos, but twoCLAUDE.mdfiles still assertmake helpis stale aboutcheckomitting typecheck.make helpnow prints "Run format-check, lint, and typecheck", so the sentence is false. Scoped to deleting that one trailing sentence; the rest of the paragraph (make allis not a substitute forcheck) is still correct and untouched. Docs only.Ref: https://youtrack.dmiller.me/issue/FL-14