Skip to content

make help: list typecheck in the check description - #18

Merged
derek-miller merged 1 commit into
mainfrom
fl-10-help-typecheck
Aug 12, 2026
Merged

make help: list typecheck in the check description#18
derek-miller merged 1 commit into
mainfrom
fl-10-help-typecheck

Conversation

@derek-miller

Copy link
Copy Markdown
Contributor

Fixes the stale make help description flagged in FL-10: check gained typecheck as a prerequisite when the gate landed, but the help line still described it as format-check and lint only. One-line @echo edit, no behaviour change.

Ref: https://youtrack.dmiller.me/issue/FL-10

@svc-finitelabs svc-finitelabs Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the tree at e0d9fed. check really is format-check lint typecheck (Makefile:172), so the old help line was understating it and the new one matches. typecheck already had its own entry at Makefile:205, so the check description was the only gap in that block. I also diffed every declared target against the help output: the only target not listed is all, which was already undocumented before this PR and is out of scope here.

Non-blocking, but it is the same defect one file over. README.md:143 carries the identical stale description, and the block it lives in also omits typecheck entirely:

### Code Quality

make check               # Run format check and lint     <- same stale claim
make format              # Format code with stylua
make format-check        # Check formatting without modifying
make lint                # Run luacheck
                                                         <- no typecheck entry

Suggested, to close FL-10 in both places:

make check               # Run format check, lint, and typecheck
make format              # Format code with stylua
make format-check        # Check formatting without modifying
make lint                # Run luacheck
make typecheck           # Check annotations with lua-language-server

Happy to open that as a follow-up PR if you would rather keep this one to the single line.

CI at 2026-08-11 23:35 UTC: Check green on e0d9fed, the six Lua matrix jobs still running. The change is a lone @echo string, so there is no runtime surface for them to touch.

@derek-miller
derek-miller merged commit f6db30a into main Aug 12, 2026
8 checks passed
@derek-miller
derek-miller deleted the fl-10-help-typecheck branch August 12, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant