Repository navigation
Move link exclusions from [tool.preen] to lychee.toml - #144
Merged
Merged
Conversation
lychee reads lychee.toml from the repo root by itself, so one list now serves preen's links check, the lychee pre-commit hook and the weekly link check. preen's next release drops link_ignore and fails a repo that still sets it. Patterns stay schemeless (a leading // marks the host boundary) because preen 0.9 scans .toml files and would read a pattern with a scheme as a link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
[tool.preen] link_ignoreintoexcludeinlychee.tomlat the repo root, comments included. lychee reads that file by itself, so preen's links check, the lychee pre-commit hook and the weekly link check (gojiplus/py-canon#134) share one list. The next preen release (gojiplus/preen#123) removeslink_ignoreand fails any repo that still sets it, so this has to land first.The patterns have no scheme, and a leading
//marks where the host begins. preen 0.9 scans.tomlfiles, so a pattern written withhttps://would be read back as a link.Checked locally with
preen check --strict --only links: it passes on both preen 0.9.0 (the CI pin) and preen main. Withoutlychee.toml, the same run reports the findings these patterns cover.🤖 Generated with Claude Code