Skip to content

Move link exclusions from [tool.preen] to lychee.toml - #17

Merged
soodoku merged 1 commit into
mainfrom
lychee-toml
Nov 16, 2026
Merged

soodoku merged 1 commit into
mainfrom
lychee-toml

Conversation

@soodoku

@soodoku soodoku commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Moves [tool.preen] link_ignore into exclude in lychee.toml at the repo root, comments included. lychee reads that file by itself, so preen's links check, the lychee pre-commit hook and the weekly link check (gojiplus/py-canon#134) share one list. The next preen release (gojiplus/preen#123) removes link_ignore and fails any repo that still sets it, so this has to land first.

The patterns have no scheme, and a leading // marks where the host begins. preen 0.9 scans .toml files, so a pattern written with https:// would be read back as a link.

Checked locally with preen check --strict --only links: it passes on both preen 0.9.0 (the CI pin) and preen main. Without lychee.toml, the same run reports the findings these patterns cover.

🤖 Generated with Claude Code

lychee reads lychee.toml from the repo root by itself, so one list now
serves preen's links check, the lychee pre-commit hook and the weekly
link check. preen 0.10 drops link_ignore and fails a repo that still
sets it.

Patterns stay schemeless (a leading // marks the host boundary) because
preen 0.9 scans .toml files and would read a pattern with a scheme as a
link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T22:57:13.107046Z 090d640 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@soodoku
soodoku merged commit e09444d into main Nov 16, 2026
12 checks passed
@soodoku
soodoku deleted the lychee-toml branch November 16, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant