Repository navigation
Add conditional include for sm.h based on AUTO_RELOAD - #521
Merged
Merged
Conversation
troglobit
approved these changes
Nov 12, 2026
troglobit
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, good finding!
Contributor
Author
|
Glad I could help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I was attempting to configure
finitversion5.0-rc1with:and the build failed with the following error in both
src/cgroup.candsrc/conf.c:All of the following solutions worked:
1- I tried removing
--enable-auto-reloadand it built fine, but I want the auto reload feature so I tried something else2- I tried passing
-Wno-implicit-function-declarationinCFLAGSand it worked, but I do not think it is a good idea3- I tried to include
sm.hconditionally based on the value ofAUTO_RELOADinsidesrc/cgroup.candsrc/conf.cand it also worked (I wonder if a conditional include is better than an absolute one here).