Fix: preserve omitted optional arguments - #1287
Merged
Merged
Conversation
Add a focused Params::Validate regression test for omitted optional arguments before diagnosing the shared backend failure. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Initialize false conditional paths rather than reusing a stale branch register. This preserves omitted optional arguments in Params::Validate and fixes DateTime::Format::Builder loading (#1283). Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Return the false condition value from an if expression without an else while explicitly materializing the interpreter result register. This keeps omitted optional arguments distinct without regressing Perl conditional semantics. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
fglock
marked this pull request as ready for review
September 7, 2026 18:18
Keep the issue 1283 regression self-contained so it runs in the standard unit test environment without requiring a locally installed CPAN module. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undeffrom untakenifexpressions without anelsein both backends.Params::Validateand DateTime formatters.undefarguments.Fixes #1283
Validation
makeparams_validate_optional_argument.ton JVM and interpreter backendsDateTime::Format::Builderreproducer on both backendst/02-schema.t(19 tests) on the interpreter