Repository navigation
feat: Add Lance optional dependencies - #6958
Conversation
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6958 +/- ##
==========================================
+ Coverage 49.44% 49.92% +0.48%
==========================================
Files 443 443
Lines 55511 55511
Branches 8096 8096
==========================================
+ Hits 27445 27714 +269
+ Misses 26168 25874 -294
- Partials 1898 1923 +25
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Need to run make lock-python-dependencies-all and pixi lock |
|
Thanks — you are right on both counts, and I want to be straight that I cannot run either command from my environment. Here is what I was able to establish, in case it saves you time.
which is the pre-change expansion and does not contain For the requirements, only I confirmed the non- One thing worth deciding before the refresh runs. I regenerated Why I cannot run it. Could you run |
|
Follow-up: I tried running both commands and
so it asks for Fix is up as #6959, with regression tests for the split shape and a check against all three committed files. Once that merges I will rerun the lock target here and push the result. One note for whoever regenerates: the target starts with
|
`feast` is an editable path dependency, so `pixi.lock` records its full `requires_dist`, including the expansion of every extra. Adding the `lance` extra therefore changes the lock even though no pixi feature consumes it. The change is confined to that one block: the `ci` expansion gains `lance`, and the two `lance` requirements are recorded. No package resolves differently, which is what the diff size shows -- 3 insertions and 1 deletion, and the 1377 pypi and 211 conda artifact URLs are unchanged. Signed-off-by: hao-xu5 <hxu44@apple.com>
|
The change is confined to the one block I expected, because + - pylance>=12.0.0 ; extra == 'lance'
+ - lance-namespace>=0.11.1 ; extra == 'lance'
- - feast[...,k8s,mcp,...] ; extra == 'ci'
+ - feast[...,k8s,lance,mcp,...] ; extra == 'ci'3 insertions, 1 deletion. Nothing resolves differently — the 1377 pypi and 211 conda artifact URLs are byte-identical to before, which is expected since none of the three pixi features consumes the
|
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
|
Updated in afe2961:
I also retried Local verification after the final master sync:
|
The three ci-requirements files conflicted only because master's docling-slim and kubernetes updates insert alphabetically adjacent to the lance entries. Both sides' insertions are kept and re-sorted, so each file is now master's content plus the lance additions with no deletions. Signed-off-by: hao-xu5 <hxu44@apple.com>
|
Please rebase |
done |
Summary
Adds an installable
lanceextra for the native Lance read/write paths:pylance>=12.0.0lance-namespace>=0.11.1feast[ci]pip install 'feast[lance]'This is split from #6943 so the data-source implementation and packaging change can be reviewed independently.
Verification
pytest sdk/python/tests/unit/infra/data_sources/test_lance_dependencies.py -qruff check sdk/python/tests/unit/infra/data_sources/test_lance_dependencies.pyruff format --check sdk/python/tests/unit/infra/data_sources/test_lance_dependencies.pypip install --dry-run '.[lance]'Related: #6943, #6945