Skip to content

feat: Offline write batch support for IcebergSource - #6829

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
ntkathole:iceberg_offline_write
Sep 22, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
ntkathole:iceberg_offline_write

Conversation

@ntkathole

Copy link
Copy Markdown
Member

What this PR does / why we need it:

When a FeatureView's batch_source is an IcebergSource, calling fs.write_to_offline_store() or fs.push(to=PushMode.ONLINE_AND_OFFLINE) was not supported.

Added Offline write batch support for IcebergSource.

@ntkathole ntkathole self-assigned this Sep 11, 2026
@ntkathole
ntkathole requested a review from a team as a code owner September 11, 2026 07:30
@codecov-commenter

codecov-commenter commented Sep 11, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 9.09091% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.60%. Comparing base (5ee7ee3) to head (71a94d6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sdk/python/feast/infra/offline_stores/duckdb.py 8.69% 21 Missing ⚠️
...ffline_stores/contrib/spark_offline_store/spark.py 10.00% 9 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6829      +/-   ##
==========================================
- Coverage   47.61%   47.60%   -0.02%     
==========================================
  Files         422      422              
  Lines       52346    52391      +45     
  Branches     7596     7605       +9     
==========================================
+ Hits        24925    24939      +14     
- Misses      25646    25676      +30     
- Partials     1775     1776       +1     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.93% <9.09%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...ffline_stores/contrib/spark_offline_store/spark.py 35.63% <10.00%> (-0.37%) ⬇️
sdk/python/feast/infra/offline_stores/duckdb.py 35.27% <8.69%> (-1.92%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee7ee3...71a94d6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntkathole
ntkathole force-pushed the iceberg_offline_write branch 2 times, most recently from cd62ae9 to bb7905e Compare September 15, 2026 07:42
@ntkathole
ntkathole force-pushed the iceberg_offline_write branch from bb7905e to 6829eb9 Compare September 16, 2026 14:46

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nitpck comment.

Comment thread sdk/python/feast/infra/offline_stores/duckdb.py
@jyejare
jyejare force-pushed the iceberg_offline_write branch from 6829eb9 to 7c68f9b Compare September 22, 2026 07:34
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
@ntkathole
ntkathole force-pushed the iceberg_offline_write branch from 7c68f9b to 71a94d6 Compare September 22, 2026 09:02
@ntkathole
ntkathole merged commit 5be5ed0 into feast-dev:master Sep 22, 2026
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants