Repository navigation
Take the document at API version 1.20.3 and fix the kept source - #11
Merged
Merged
Conversation
The curated document moves from API 1.20.0 to 1.20.3. Only info.version changed. Paths, operations and schemas are the same. curate.py --vendor dropped ErrorEnvelope and ErrorBody from the kept source. Only the shared responses point at them, and strip_source did not follow those. Curating scripts/server-openapi.json then stopped with KeyError 'ErrorEnvelope'. strip_source now follows the shared responses. --vendor refuses a kept source that curates to a different document. truthcheck curates the kept source, so CI catches it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curated document moves from API 1.20.0 to 1.20.3. Only info.version changed.
curate.py --vendor dropped ErrorEnvelope and ErrorBody from the kept source. Only the shared responses point at them. Curating scripts/server-openapi.json then stopped with KeyError 'ErrorEnvelope'.
strip_source now follows the shared responses. --vendor refuses a kept source that curates to a different document. truthcheck curates the kept source in CI.
Checked locally: curate --check against the live document and the kept source, build_reference --check, truthcheck, Redocly lint.