Add sorting to Skunk HTML report - #142
poonambhagaur61-tech wants to merge 2 commits into
Conversation
JuanVqz
left a comment
There was a problem hiding this comment.
Hey @poonambhagaur61-tech, Thanks for taking the time to contribute. I reviewed and have some questions for the issue creator. Feel free to share your opinions as well.
As for me, the changes looks good in general, so, let's wait for him, but if no response we can decide what to do, thanks!
There was a problem hiding this comment.
When loading the report, the arrow icons do not show up
They should be visible like so; however, I'm unsure if they show a neutral hint or the actual initial sort preference. The reports start with:

For the neutral hint, I added this .table-header::after { content: " ⇅"; opacity: .35 }
@fbuys,
Would you be happy with a neutral hint or more like an initial arrow that matches the actual pre-sorted order?
And, since you are around, what do you think about the sorting implementation? As for the code, I'd say it looks good, but as for what columns you want to be sorted, What are the criteria to follow, etc.?
There was a problem hiding this comment.
Thank you for the helpful feedback. I’ve updated the report to indicate the initial sort direction. Since the report is initially sorted by Skunk Score in descending order, the Skunk Score column now displays the descending arrow by default, while the other columns remain neutral until selected. I’ve also kept the existing numeric and alphabetical sorting behavior unchanged.
Please let me know if you have any further suggestions or would prefer a different sorting behavior. Thank you again for your guidance!
This PR adds sortable columns to the Skunk HTML report.
Tests: 88 runs, 126 assertions, 0 failures, 0 errors, 0 skips