Repository navigation
fix(ci): gate language jobs on their project entry point on diff runs too - #372
Merged
Merged
Conversation
… too The rust/python/frontend entry-point checks only ran in the forced-run inventory, so on a normal PR any matching file (a static .js in a Rust repo, testdata .rs, helper .py) started a job that then failed. The checks now live in one step that runs in both modes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P2coHXurAM9VQCm1XCHxnS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reusable CI's
detect-changesjob only checked whether a matching file belongs to a buildable project on forced runs. On a normal PR diff, any matching file started the language job, which then failed:.js,.cssor.htmlfile startedfrontend-ci, even with nopackage.json;.rsfile startedrust-ci, even with no rootCargo.toml;.pyfile startedpython-ci, even with no Python package.This blocked falkcorp/cockroach-rollout-agent#34. It is a Rust binary that embeds a static
app.jsandapp.css, has nopackage.json, and failedFrontend CIon every PR touching them.Issues Addressed
fix(ci): gate language jobs on their project entry point on diff runs too
Description: The three checks move out of the forced-run
Inventory tracked filesstep into a newGate categories on their project entry pointsstep. It runs on both diff and forced runs and reads the raw paths-filter or inventory result.Get frontend working directorynow always runs, so the gate resolvespackage.jsonexactly wherefrontend-ciwould install from. The job outputs and the debug summary forrust-files,python-filesandfrontend-filesnow come from the gate. The other categories are unchanged.Files Modified:
.github/workflows/reusable-ci.yml: the new gate step. The inventory step now only records raw hits. The header is bumped to 1.17.0..github/guid-index.json: the version bump, regenerated by the pre-commit hook.changelog.d/20261011-entry-point-gate-diff-runs.md: changelog fragment.Testing
actionlintv1.7.1 (the version this workflow pins) is clean on the file.true, pythonfalse, frontendfalse(nopackage.json)false(no rootCargo.toml), pythontrue, frontendtruefalseBreaking Changes
None intended. Repos that do have the entry point behave exactly as before. Repos without it now skip a job that could only fail.
🤖 Generated with Claude Code
https://claude.ai/code/session_01P2coHXurAM9VQCm1XCHxnS