Repository navigation
feat(reusable-ci-minimal): add a run-go-tests input (default true) - #371
Merged
Merged
Conversation
Callers that shard the short Go suite themselves (audiobook-organizer's 07-C3, four shards plus a coverage-merge job) need to switch off the built-in `Go Tests (short, race)` job without losing Go Vet & Build, Go Lint, the frontend jobs or the summary. The new boolean input defaults to true, so no existing caller changes behaviour; ci-minimal-summary already treats a skipped job as not failed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015yVABDgW5vRPPprhhFYZuQ
github-actions
Bot
added
size/M
github-actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers that run their own sharded Go test jobs need to switch off the built-in
Go Tests (short, race)job (go-test-short, line 119 at SHA 828afb5) without losingGo Vet & Build,Go Lint, the frontend jobs or the summary.This adds
inputs.run-go-tests(type: boolean,required: false,default: true, description "Run the built-in Go Tests (short, race) job; set false when the caller runs its own") and gates that one job withif: ${{ inputs.run-go-tests }}. Behaviour for existing callers does not change (default true). No change toci-minimal-summaryis needed: it already treats a skipped job as not failed (it only fails onfailure) and lists it as "skipped" in the summary table.First caller: falkcorp/audiobook-organizer, brief 07-C3 (four-shard short-test run with a coverage-merge job). The GUID index regenerated by the pre-commit hook is included.
yaml.safe_loadandactionlintclean. Changelog fragment added.🤖 Generated with Claude Code
https://claude.ai/code/session_015yVABDgW5vRPPprhhFYZuQ