Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/pr-automation.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# file: .github/workflows/pr-automation.yml
# version: 4.5.8
# version: 4.5.9
# guid: a7b8c9d0-e1f2-3456-a789-0123456789bc
# NOTE: This file should be updated in ghcommon repository first, then copied to other repositories.
# To update: Edit in https://github.com/falkcorp/github-common/.github/workflows/pr-automation.yml then copy to other repos
Expand All @@ -19,8 +19,12 @@ on:
# The group includes event_name: one push fires both a pull_request and a
# pull_request_target run, and with a shared group whichever arrives second
# cancelled the other, leaving its jobs as red "cancelled" checks on every PR.
# It also includes the action: an `edited` or `labeled` event on the same head
# commit otherwise cancelled the in-flight `synchronize`/`opened` run, and those
# cancelled jobs stay red on that commit. A new push (`synchronize` after
# `synchronize`) still supersedes the older run, which is what we want.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.action }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

permissions:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Fixed

#### pr-automation: an edit or label no longer cancels the run for the same commit

- The concurrency group now also includes `github.event.action`. Editing a PR body seconds after a push cancelled the push's `synchronize` run (seen on #365: Code Quality Check, Auto Label PR and AI Rebase stayed red as "cancelled" on the head commit even though the later run passed them). A new push still supersedes the previous push's run.
Loading