Skip to content

fix(ci): skip dead Go coverage rerun without .testcoverage.yml; go-ci cap 40m - #365

Merged
jdfalk merged 1 commit into
mainfrom
ci/go-ci-skip-dead-coverage-rerun
Oct 5, 2026
Merged

jdfalk merged 1 commit into
mainfrom
ci/go-ci-skip-dead-coverage-rerun

Conversation

@jdfalk

@jdfalk jdfalk commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

The reusable go-ci job runs the full suite twice: once in "Test Go project" (with the real coverage gate), then again in "Generate Go coverage profile", whose output only feeds go-test-coverage, which exits immediately when .testcoverage.yml is missing. In audiobook-organizer that dead rerun takes 6–8 min and pushes go-ci (28–30 min) past its 30-min cap; main itself was cancelled at 30m on 2026-10-04 23:05.

  • Both coverage steps now run only when the repo has .testcoverage.yml (repos that have it behave exactly as before).
  • go-ci timeout-minutes 30 → 40, so a hung test is killed by Go's 10m test timeout with a goroutine dump instead of a bare runner cancel.

Owner-approved 2026-10-05.

The six red PR Automation checks on the first push

Run 37265215047 (pull_request) showed Code Quality Check, Auto Label PR, Intelligent AI Labeling, PR Analysis, Breaking Changes Check and AI Rebase & Conflict Resolution as failed. None of them ran: all six were CANCELLED at 0s with the annotation Canceling since a higher priority waiting request for PR Automation-365 exists. The pull_request_target run for the same push (37265215038) shared the concurrency group PR Automation-365 and cancelled it. The same race left red cancelled checks on dependabot PRs #363 and #364, so it was repo-wide and unrelated to this change. No AI/labeling secret or quota problem was involved; Intelligent AI Labeling passed in the surviving run.

Fixed separately in #366 (concurrency group now includes github.event_name), merged as 64d4295. This branch was rebased onto it so the new push exercises the fix.

That push exposed a second variant: a body edit 10s after the push cancelled the push's synchronize run for the same head commit (run 37265745629; Code Quality Check, Auto Label PR, AI Rebase left CANCELLED although the later run passed them). Fixed in #368 (group also keyed on github.event.action), merged as d650bfb, and this branch rebased onto it again.

🤖 Generated with Claude Code

https://claude.ai/code/session_017MtQ5LP2n3t3bs7AhptkKJ

@jdfalk
jdfalk force-pushed the ci/go-ci-skip-dead-coverage-rerun branch from 5b4f12d to e33e12c Compare October 5, 2026 04:58
@github-actions github-actions Bot added size/S github-actions GitHub Actions related work type:documentation Improvements or additions to documentation module:config Configuration management workflow:github-actions GitHub Actions workflows labels Oct 5, 2026
…o-ci cap 40m

The Generate step re-ran the full suite for a checker that exits at once
when .testcoverage.yml is missing, pushing go-ci past its 30m cap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017MtQ5LP2n3t3bs7AhptkKJ
@jdfalk
jdfalk force-pushed the ci/go-ci-skip-dead-coverage-rerun branch from e33e12c to 49a741f Compare October 5, 2026 05:05
@jdfalk
jdfalk merged commit 8eb9a5a into main Oct 5, 2026
60 checks passed
@jdfalk
jdfalk deleted the ci/go-ci-skip-dead-coverage-rerun branch October 5, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions GitHub Actions related work module:config Configuration management size/S type:documentation Improvements or additions to documentation workflow:github-actions GitHub Actions workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant