Skip to content

Implement RBAC message discarding filters - #407

Merged
RalphSteinhagen merged 2 commits into
mainfrom
rbacfilters
Aug 25, 2026
Merged

Implement RBAC message discarding filters#407
RalphSteinhagen merged 2 commits into
mainfrom
rbacfilters

Conversation

@magnusg-kdab

@magnusg-kdab magnusg-kdab commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

In order to be flexible with the message discarding, this uses a generic predicate to be able to configure the discarding rules.

Closes #403

@magnusg-kdab magnusg-kdab self-assigned this Jul 8, 2026
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 8, 2026 09:44 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 8, 2026 09:44 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 13, 2026 13:17 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 13, 2026 13:17 — with GitHub Actions Inactive
@magnusg-kdab
OAuth: Call redirect with httplib
b2e48d7 
A missing trailing slash caused opencmw::URI to return no path.
The best solution would be to add a fallback "/" root path to
opencmw::URI, in case no path is present. However, this would trigger
the assert in URI::returnOpt that checks if the returned string is part
of the original provided string. Therefore we opt for this less invasive
change.

Signed-off-by: Magnus Groß <magnus.gross+github@kdab.com>
@magnusg-kdab
Add RBAC message discarding filters
73a842c 
Signed-off-by: Magnus Groß <magnus.gross+github@kdab.com>
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 13, 2026 13:40 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 13, 2026 13:40 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 13, 2026 13:40 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage July 13, 2026 13:40 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage August 13, 2026 12:22 — with GitHub Actions Inactive
@magnusg-kdab
magnusg-kdab temporarily deployed to configure coverage August 13, 2026 12:22 — with GitHub Actions Inactive
@sonarqubecloud

sonarqubecloud Bot commented Aug 13, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
36.5% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

RalphSteinhagen
RalphSteinhagen approved these changes Aug 25, 2026
View reviewed changes

@RalphSteinhagen RalphSteinhagen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magnusg-kdab thanks for the update/missing-feature fix. Looks goot.

N.B. sorry for having kept this dangling for so long 🙈 .

Can be merged once the CI passes.

@RalphSteinhagen
RalphSteinhagen merged commit 57a7a45 into main Aug 25, 2026
15 of 18 checks passed
@RalphSteinhagen
RalphSteinhagen deleted the rbacfilters branch August 25, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees

@magnusg-kdab magnusg-kdab

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[2SP] Integrate RBAC into GNU Radio 4 message handling

2 participants

@magnusg-kdab @RalphSteinhagen