chore: Upgrade to Chokidar v5 - #12413
Draft
slorber wants to merge 2 commits into
Draft
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.3 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.5 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade dependency for maintenance reasons
Changelogs:
The main breaking change is the drop of globbing support, which we unfortunately use:
https://github.com/paulmillr/chokidar#upgrading
Stuck
Currently stuck because using Node glob/globby only resolves existing files that match patterns, but it won't help watching dirs when using
docs/**/*.{md,mdx}, so additions/deletions won't be watched.See also paulmillr/chokidar#1423
Code that removed glob support is not easy to understand/backport: paulmillr/chokidar@cac97c6#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80
A possible solution would be something like this:
Test Plan
CI
Local tests: adding/editing/removing files/folders should trigger both site/plugin reloads.
MDX editions should not just hot reload (handled by bundler) but also recompute metadata and adjust the experience accordingly.
Test links
https://deploy-preview-12413--docusaurus-2.netlify.app/