Skip to content

cmake: prefer glog's own CMake config over the FindGlog module #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michel-slm wants to merge 1 commit into from
+14 −0
Closed

cmake: prefer glog's own CMake config over the FindGlog module #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cachelib/cmake/FindGlog.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,23 @@
# GLOG_FOUND - system has Glog
# GLOG_INCLUDE_DIRS - the Glog include directories
# GLOG_LIBRARIES - link these to use Glog
# glog::glog - imported target, preferred over the variables above

include(FindPackageHandleStandardArgs)

# glog >= 0.7 only compiles when consumers see its exported target, which
# carries the GLOG_USE_GLOG_EXPORT definition. Prefer the upstream config and
# derive this module's documented variables from it; GLOG_LIBRARIES names the
# target so that linking through the variable still picks up the definition.
find_package(glog CONFIG QUIET)
if (TARGET glog::glog)
get_target_property(GLOG_INCLUDE_DIR glog::glog INTERFACE_INCLUDE_DIRECTORIES)
set(GLOG_INCLUDE_DIRS ${GLOG_INCLUDE_DIR})
set(GLOG_LIBRARIES glog::glog)
set(GLOG_FOUND TRUE)
return()
endif()

find_library(GLOG_LIBRARY glog
PATHS ${GLOG_LIBRARYDIR})

Expand Down
Loading