Skip to content

fix(ci): run selected jobs after skipped policy checks - #257

Merged
f0rr0 merged 1 commit into
mainfrom
f0rr0/fix-selected-ci-skipped-ancestors
Oct 6, 2026
Merged

f0rr0 merged 1 commit into
mainfrom
f0rr0/fix-selected-ci-skipped-ancestors

Conversation

@f0rr0

@f0rr0 f0rr0 commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Selected-product qualification can intentionally skip the Policy matrix. Nine downstream jobs still used GitHub's implicit success() condition, which propagates that skip through the ancestor chain even after the source gates and actual producers succeed. Qualification run 37420502874 consequently skipped required WASIX, native/mobile packaging and E2E jobs, and publication stopped before assembly.

Override the implicit status check in those nine conditions while explicitly requiring every direct producer to succeed. Preserve selection predicates, dependency edges and the strict Builds, E2E, Required and Qualified gates. Extend the existing parsed-workflow contract to reject downstream conditions that inherit optional source skips. GitHub documents the default status check.

Validation:

  • bash tools/ci/check-workflows.sh passed, including pinned actionlint/zizmor and all workflow/planner/transfer tests.
  • The added regression check failed against the original workflow and passed after the fix.
  • A local replay using the failed run's actual plan reproduced all nine original skips; the fixed expressions admit successful producers and reject skipped, failed or cancelled prerequisites, failed Policy, run cancellation and unselected work. This replay does not replace hosted qualification.
  • Biome and git diff --check passed.

After merge, qualify the exact main commit and then publish the seven versions from pending release PR #250. Rerunning the old SHA cannot apply this workflow fix.

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
oliphaunt-docs Ready Ready Preview Oct 6, 2026 7:01am UTC

@f0rr0
f0rr0 merged commit e6fb8a4 into main Oct 6, 2026
66 checks passed
@f0rr0
f0rr0 deleted the f0rr0/fix-selected-ci-skipped-ancestors branch October 6, 2026 07:06

This branch was successfully deployed

1 active deployment
Preview — b33d871a Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant