Skip to content

fix(native): preserve PostgreSQL fsync default - #241

Open
f0rr0 wants to merge 2 commits into
f0rr0/patch-correctness-refreshfrom
f0rr0/native-fsync-default
Open

f0rr0 wants to merge 2 commits into
f0rr0/patch-correctness-refreshfrom
f0rr0/native-fsync-default

Conversation

@f0rr0

@f0rr0 f0rr0 commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Native startup always supplied -F, overriding PostgreSQL's fsync default and persisted fsync=on. Remove it from the shared native runtime so direct and broker mode honor PostgreSQL's default and configuration precedence. Callers can still opt out through existing startup GUC APIs; no new setting or parser.

  • Test default fsync=on, explicit opt-out, persisted configuration, and caller overrides.
  • Keep full_page_writes and synchronous_commit independently configured.
  • Document the corrected default and the crash-corruption risk of opting out. Durable writes can take longer.

Based on #218. This PR changes native startup configuration, not initialization/publication barriers or WASIX synchronization.

Validation

Earlier hosted qualification passed native builds and packaged smokes on Linux x64/arm64, macOS arm64 and Windows x64, native SDK consumers, and all 39 native extension lifecycle cases. The latest failed run was blocked by Swift/React Native carrier version mismatches and independently versioned WASIX extension lookup, not an fsync assertion.

Rebased onto main 207fcfa5 through #218, incorporating #253's fixes for those packaging failures. The native patch and tests are unchanged. The shared workflow gate, release metadata/version-pin checks, WASIX packaging, Node-API, Swift packaging and React Native source tests pass locally. Fresh hosted qualification is required for this head. Clean reopen tests do not prove power-loss safety.

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
oliphaunt-docs Ready Ready Preview Oct 5, 2026 7:24am UTC

@f0rr0

f0rr0 commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner Author

Rebased onto main 207fcfa5 through refreshed #218. Current head: 4d75d803ba97a7357e6524969b64fe9a60b670e1.

Fresh CI is running for that exact head.

The failed run 37243819824 predates #253. Its Swift/React Native carrier mismatches and pg_hashids archive lookup are addressed by that merged change. The fsync patch and regression tests are unchanged.

Local shared workflow, release metadata/version-pin, WASIX packaging, Node-API, Swift packaging and React Native source checks pass. Fresh hosted CI is pending; the old failed run is not evidence against the rebased head.

This branch was successfully deployed

1 active deployment
Preview — 4d75d803 Deployed Oct 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant