check struct field name is a string in Fetch and get#973
Open
netliomax25-code wants to merge 1 commit into
Open
check struct field name is a string in Fetch and get#973netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
Author
|
any update? |
sanmaxdev
approved these changes
Jul 13, 2026
sanmaxdev
left a comment
sanmaxdev
left a comment
There was a problem hiding this comment.
The struct-key guard is consistent across get and runtime field access, and both paths have regression coverage.
Passed:
go test ./...git diff origin/master...HEAD --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime.Fetch (runtime.go:76) and the get builtin (lib.go:598) read a struct field name with an unchecked i.(string), so indexing a struct held in an any value with a non-string key panics with a raw interface conversion. Use a checked assertion so Fetch falls through to its usual "cannot fetch" error and get returns nil per its no-panic contract.