catalog-import-merge: gg-audio (new=0 discontinued=0 updated=2) - #681
catalog-import-merge: gg-audio (new=0 discontinued=0 updated=2)#681jeffreylouden wants to merge 1 commit into
Conversation
Merge refresh via /catalog-import-merge. Tier: AUREO-531 Details refreshed: 2 Price corrections: 1 New entries: 0 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9ca1d57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
On-demand reviews are free for the next 22 days. After that, they cost $0.25 per reviewed file. Or wait 18 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 86 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
github-actions
Bot
added
the
ready-for-review
1 participant
Merge plan
Refresh of both existing GG Audio entries. No products added, removed, or marked discontinued. Both keep their ID, name and URL.
ggaudio.comis dead — it 404s and is parked for sale on HugeDomains. That is also why pre-staged discovery came back empty for this brand. Both catalog entries already point at cherryaudio.com, because Cherry Audio acquired these products, so the refresh ran against those live pages.What the pages actually say, quoted rather than inferred:
The Blue3 product page header reads
Blue3 Tonewheel Organ | Instruments | Cherry Audio, andstore.cherryaudio.com/manufacturerscarries no GG Audio entry at all. GG Audio now appears only as provenance and as an upgrade-eligibility condition for prior owners.Read literally, that is a completed acquisition in which Cherry Audio is the developer and seller. It is a case for re-attributing both entries to
cherry-audio, or for marking thegg-audiomanufacturer defunct. This routine is not making that call — manufacturer identity anddefunct: trueare human decisions, and the catalog's own guidance is explicit thatdefunctmust not be set casually. Nothing in this PR changesmanufacturer.What changed
data/software/gg-audio-blue3.yamldetails,specs,prices,videosdata/software/gg-audio-spin.yamldetailsdetailsblocks were broken and are now real prose. They previously held scraped label fragments rather than sentences — Blue3's was200+ / Classic 122 / 147 / RA-200, Spin's wasLeslie 122 / Leslie 147 / … / Pre / Post / 3-band / Low. Blue3 goes from 201 to 1,468 characters and Spin from 238 to 884, all of it verbatim page prose.0 USD; the page lists $49.00 with no sale markers (no strikethrough, no "was", no sale string in the HTML). Corrected.3f6DgQLl5Yc,I17qynSdpgw). Neither iframe carries atitleattribute, so no title was recorded rather than inventing one.Every change is additive; no field shrank.
Held back by the operator
descriptionon both entries — withheld. Both existing descriptions are curated and not stale; the extracted values differ in voice rather than fact. Same treatment as the other two brands in this run.primaryCategoryon Blue3 — withheld. Extraction proposesvirtual-instrument→organ, which is arguably more accurate, but reclassifying an existing entry is a judgement call. Worth a follow-up.legacyon Spin's categories — withheld. The rest of Spin's newcategories(effect,emulation,plugin) applied;legacywas stripped. See below.Spin needs a human, on two counts
1. Its URL is a news article, not a product page. No product page exists:
/products/spinand/products/spin-rotary-speakerboth 404, Spin is absent from the 46-entry products index and from all 1,479 sitemap URLs. The only live listings are two store SKUs,spin-legacy-macos-installerandspin-legacy-windows-installer, both free. The current/news/URL is the best descriptive page that exists, but it is not a product page, and the alternative is a store URL, which catalog convention discourages. Left unchanged.2. Is Spin legacy? The evidence is real but indirect: no product page, absent from the index and sitemap, and the only live listings are named "Spin Legacy … Installer" and priced free. Against that, nothing 404s or 410s at the recorded URL, no page carries a Legacy or Discontinued badge, and no page says "no longer available". Because the evidence comes from store SKU names rather than the entry's own URL, the
legacytag was not applied. Someone should decide.Also unverifiable: Spin's stored requirement "macOS 10.9 – 12.x" could not be re-confirmed from any live Cherry Audio page, so its
specswere left untouched.Data review
pnpm validatescoped and unscoped clean (16,770 entries, 0 errors, 0 warnings),pnpm buildclean, no duplicate or invalid IDs.Audit trail
scripts/catalog-import/data/gg-audio/inventory.jsonscripts/catalog-import/data/gg-audio/merge-plan.jsonscripts/catalog-import/data/gg-audio/extracted/(2)Tier issue: AUREO-531. The tier line's URL for this brand (
https://ggaudio.com/) is dead and should be corrected or the line retired; this routine does not edit the human-authored prose on a tier line.Auto-merge gate: batched human review.