Skip to content

Store Required Checks within the repo - #688

Merged
iHiD merged 1 commit into
mainfrom
required-checks
Nov 8, 2026
Merged

iHiD merged 1 commit into
mainfrom
required-checks

Conversation

@iHiD

@iHiD iHiD commented Nov 8, 2026

Copy link
Copy Markdown
Member

Currently, "required checks" on PRs are hidden from maintainers, and can get out of sync with the reality of a repo. To fix this, we're adding a .github/required-checks.yml file, which lists the checks that must pass before a PR can merge into main.

When this file is changed, the ruleset that manages branch protection automatically gets synced up. The new Required checks workflow checks that all the checks listed in required-checks.yml exist.

(Sidenote: I'm increasingly wary of agents that have access to GitHub mistakenly (or potentially nefariously) doing things that could do us damage or cause us to have unexpected or high costs. That's why I'm using CODEOWNERS on a more frequent basis for files that are always worth just getting a second pair of eyes on. It's not a reflection on trust for maintainers 🙂)

The file adds the following Required Checks:

  • check-formatting
  • configlet / configlet
  • i18n / completeness
  • Validate required checks (rather recursively, I admit!)

For many repos (including Lua), the exercise tests are named with version (e.g. Test (Lua 5.4) and Test (Lua 5.5)). Those names change whenever a version is bumped, which is quite unstable, and then the required checks break. I'm going to fix that separately by adding a check with a more standard name (e.g. "tests"), which can rely on the unstably named tests, and add that to this file. That'll be a separate PR.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@iHiD
iHiD requested a review from a team as a code owner November 8, 2026 06:31
@iHiD
iHiD merged commit faf0ac8 into main Nov 8, 2026
8 checks passed
@iHiD
iHiD deleted the required-checks branch November 8, 2026 08:14
@iHiD iHiD mentioned this pull request Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant