fix: OR logic in conditional group evaluation - #3
Open
beanZ9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose this change in evaluation logic since currently OR conditions are without function, i.e. they don't affect whether a sequence step passes or fails. If a step has only OR groups, it always passes.
With this change the pseudo logic for the evaluation of each step becomes a logical AND of:
Considering there is no indication of any more complex order or priority in which the groups are evaluated I believe this to be the most intuitive approach.
This will theoretically change behavior of existing crafting sequences but I doubt anyone is currently relying on OR groups being duds? 🤷