fix: verify tevm-test release readiness - #2
Open
roninjin10 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Verification run locally
pnpm install --frozen-lockfile: passed from a fresh clone (1,069 packages)pnpm lint: passed, 177 files checkedpnpm typecheck: passed in all five projectspnpm build: passed; all three packages emitted ESM, CJS, and declaration output; Vocs 2.7.2 generated 35 static filesactionlint .github/workflows/*.yml: passednpm pack --dry-run --json: passed for@tevm/test-matchers,@tevm/test-node, and@tevm/test-utils@tevm/*dependency at1.0.0-rc.151was confirmed on npm and uses a caret range; the onlyworkspace:^dependency is the private intra-repository matcher integration packagepnpm --filter @tevm/test-matchers-integration test: 11 files passed; 229 tests passed, 11 skipped; no type errorspnpm test: failed.@tevm/test-utilspassed 5/5 and@tevm/test-matcherspassed 89/89.@tevm/test-nodereported 28 failed files, 23 passed files, 6 skipped files, 200 passed tests, 44 skipped tests, 7 todo tests, and 56 startup errors.Known release blocker
The cached mainnet block contains EIP-4844 transactions. Published
@tevm/common@1.0.0-rc.151losescustomCrypto.kzgafter nestedCommon.copy()calls.@tevm/nodeperforms those nested copies during fork initialization, soclient.tevmReady()fails with:A direct reproduction confirmed the original common and its first copy retain KZG, while the second wrapper copy does not. This must be fixed and published from the core
evmts/tevmrepository, then consumed here with a caret range. This PR intentionally makes that real startup failure block CI and publishing instead of leaving a timing-dependent false green.Human configuration still required
NPM_TOKENwith publish rights for the three@tevm/test-*packages, or explicitly migrate the workflow to npm trusted publishingdocs, bindtest.tevm.sh, and addVERCEL_TOKEN,VERCEL_ORG_ID, andVERCEL_PROJECT_IDto thedocsenvironment; the current environment has no secrets and the domain returnsDEPLOYMENT_NOT_FOUNDTEVM_RPC_URLS_OPTIMISMif the optional live RPC fixture must execute in CI; the workflow now consumes it