fix(search): expose shop payment readiness independently of stock by ilyar · Pull Request #58 · ever-guild/AgentShelf

ilyar · 2026-11-10T19:24:15Z

Search results showed stock availability even when the shop could not accept payment. This adds paymentReady and paymentUnavailableReason using the same route and sender checks as checkout, so assistants can explain why payment is unavailable before offering it

Stock availability, ranking, filters, prices and demand tracking retain their existing meaning. Payment and booking tools remain authoritative and recheck readiness before writing

The candidate also includes receipt and Catalog acceptance tests, review-state transition tests, and a cleanup-only timeout for disposable test databases. It does not diagnose the disputed production order or claim verified production webhook receipts

Rebased on 234f6abd92664fbcbdcbf7811e476a98d93df143, preserving the new homepage and seller assistant screens. Only CHANGELOG conflicted, both upstream entries and the readiness entry are retained. The seven implementation and test commits remain patch-identical to the previously reviewed candidate

Validation and delivery results are recorded in the latest progress comments. Integration is fast-forward only, without a merge commit

Refs: #5, #19

Runs the platform webhook handler against a migrated database and checks the read-only receipts aggregate for each delivery outcome. Refs: #19

Covers when a platform shop's published products are not_configured, pending, synced or failed, and what plain sync and retries do to rows published before the connection was ready. Refs: #19

The handler matches an event to its order by PayPal order id; whether a receipt naming another capture should end processed is not a requirement. The evidence query already excludes it. Refs: #19

Refs: #19

Refs: #5 Refs: #19

…evidence Refs: #19

DROP DATABASE waits for a checkpoint; with many parallel workers on a local disk its sync exceeded the default 10 s hook timeout. Only this hook changes. Refs: #19

ilyar · 2026-11-10T20:27:41Z

The user has requested completion and a fast-forward integration of this candidate

The previous candidate passed GitHub lint, the full test suite and production build
Rebase onto current main, preserving the newer seller UI and documentation
Check the rebased result locally and in PR CI
Fast-forward main without a merge commit, then verify delivery of the resulting SHA

@ppmarkek Integration is in progress, the original scoped search contract remains unchanged, there is no request to pause unrelated work
Production order diagnostics are separate and do not block this fix

Document the search readiness snapshot and its limits for buyer assistants. Refs: #19

chatgpt-codex-connector · 2026-11-10T20:30:48Z

Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	❌ Failed 2026-11-10T20:30:44.376590Z We couldn’t complete this review. Comment `@codex review` to try again.	`a8530bc`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-11-10T20:30:49Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

ilyar · 2026-11-10T20:31:02Z

Rebased candidate: a8530bc, based on current main 234f6ab

Preserved both new upstream UI changes, only CHANGELOG required conflict resolution
Range-diff confirms seven implementation/test commits are patch-identical
Local lint, diff check and full standard PostgreSQL 17 suite: 107 files, 1,894 tests
Draft status removed
Rebased production build in CI, local Turbopack was blocked by EPERM when creating a process/port
Fast-forward main and verify the exact deployed SHA

No payment, production SQL or infrastructure configuration was changed

ilyar · 2026-11-10T20:35:35Z

Fast-forward integration completed: main advanced from 234f6ab to a8530bc, with no merge commit

Rebased onto current main and preserved both upstream UI changes
Local lint and standard PostgreSQL suite: 1,894 tests
Rebased PR CI: lint, full tests and production build passed
Fast-forward main, PR marked MERGED by GitHub
Main CI and Render delivery
Exact-SHA live health/readiness and MCP search readiness fields

Production order diagnosis and uninspected receipts remain separate open evidence, this integration does not close #19

ilyar · 2026-11-10T20:42:23Z

PR #58 is integrated and deployed: a8530bc, fast-forward from 234f6ab, no merge commit

Latest main preserved, CHANGELOG conflict resolved without dropping either upstream entry
Local lint and full PostgreSQL 17 suite: 1,894 tests across 107 files
PR CI and main CI + delivery passed, including production build
Render deploy dep-dbpo1kugekts73ekhe70 is live on the same SHA
Independent public home, health and readiness checks passed at 20:41 UTC on 10 November
Live MCP tools/list and search_products confirmed the description and additive fields: 6 results, 4 payment-ready and 2 not_connected
Liepāja Phone Workshop reports paymentReady=true, Demo Phone Workshop reports false/not_connected, independently of availability
No private routing columns leaked into search results, no order, booking or payment was created by this verification

@ppmarkek The scoped search candidate is now on main and live, the temporary one-writer reservation for catalog.ts and the search contract is finished

This closes the readiness integration, not the remaining #19 evidence work: disputed-order diagnosis, production receipts and Catalog findings are separate

ilyar mentioned this pull request Nov 10, 2026

MCP: expose validated search and checkout tools over Streamable HTTP #5

Closed

3 of 4 tasks

ilyar added 7 commits November 10, 2026 21:27

test(webhooks): pin evidence for verified and processed capture receipts

d5d5627

Runs the platform webhook handler against a migrated database and checks the read-only receipts aggregate for each delivery outcome. Refs: #19

test(catalog): pin sender readiness and failure statuses

06b81eb

Covers when a platform shop's published products are not_configured, pending, synced or failed, and what plain sync and retries do to rows published before the connection was ready. Refs: #19

test(webhooks): do not pin the receipt kept for a foreign capture id

0c6ad20

The handler matches an event to its order by PayPal order id; whether a receipt naming another capture should end processed is not a requirement. The evidence query already excludes it. Refs: #19

test(webhooks): pin the prefix cohort receipts evidence

7ac137c

Refs: #19

feat(search): report whether a shop can take payment

d51b7cb

Refs: #5 Refs: #19

test(orders): pin cancelled to review_required transitions and their …

5ae3956

…evidence Refs: #19

test: give the test database cleanup hook its own timeout

f368b29

DROP DATABASE waits for a checkpoint; with many parallel workers on a local disk its sync exceeded the default 10 s hook timeout. Only this hook changes. Refs: #19

docs(mcp): describe payment readiness fields

a8530bc

Document the search readiness snapshot and its limits for buyer assistants. Refs: #19

ilyar force-pushed the jon/readiness-integration-19 branch from 010e52d to a8530bc Compare November 10, 2026 20:30

ilyar marked this pull request as ready for review November 10, 2026 20:30

ilyar merged commit a8530bc into main Nov 10, 2026
2 checks passed

ilyar temporarily deployed to agentshelf-e5bk.onrender.com November 10, 2026 20:38 — with GitHub Actions Inactive

ilyar mentioned this pull request Nov 10, 2026

Documentation: provide reproducible setup and integration evidence #19

Open

16 of 18 tasks

Navigation Menu

Repository navigation

fix(search): expose shop payment readiness independently of stock - #58

fix(search): expose shop payment readiness independently of stock#58
ilyar merged 8 commits into
mainfrom
jon/readiness-integration-19

ilyar commented Nov 10, 2026 •

edited

Loading

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ilyar commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 10, 2026

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

ilyar commented Nov 10, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ilyar commented Nov 10, 2026 •

edited

Loading