ci: migrate CodeQL to self-hosted ARC runner (master) - #160
Conversation
Migrate the CodeQL analyze job off GitHub-hosted ubuntu-latest onto our self-hosted ARC fleet via vars.RUNNER_LINUX_X64_4 (smallest pool per security-scan policy), keeping the ubuntu-latest fallback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| analyze: | ||
| name: Analyze | ||
| runs-on: ubuntu-latest | ||
| runs-on: ${{ vars.RUNNER_LINUX_X64_4 || 'ubuntu-latest' }} |
There was a problem hiding this comment.
Self-hosted runner risk for
pull_request-triggered CodeQL
This workflow runs on pull_request events, meaning a contributor submitting a fork PR will have their code checked out and built (autobuild) on the self-hosted ARC runner. GitHub's security hardening guide explicitly warns that public repos should avoid self-hosted runners for pull_request triggers because a malicious PR can execute arbitrary code on the runner host, potentially exfiltrating secrets or pivoting inside the ARC fleet. If the repository is public (or accepts PRs from untrusted forks), consider restricting self-hosted runners to the push trigger only and keeping pull_request on ubuntu-latest.
| analyze: | ||
| name: Analyze | ||
| runs-on: ubuntu-latest | ||
| runs-on: ${{ vars.RUNNER_LINUX_X64_4 || 'ubuntu-latest' }} |
There was a problem hiding this comment.
Smallest runner pool may be insufficient for CodeQL
The _4 suffix per the PR description designates the smallest pool in the ARC fleet. CodeQL analysis — especially with +security-and-quality queries over a JavaScript codebase — typically requires at least 8 GB of RAM and several GB of free disk space. On an under-resourced runner the job can fail with OOM or disk-full errors mid-analysis, silently dropping security coverage for a push to master. Confirm that runners in the RUNNER_LINUX_X64_4 pool meet CodeQL's minimum hardware requirements before relying on them for this scan.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Migrate the CodeQL
analyzejob from GitHub-hostedubuntu-latestto our self-hosted ARC fleet via${{ vars.RUNNER_LINUX_X64_4 || 'ubuntu-latest' }}(smallest pool, per security-scan-runs-on-_4 policy), retaining theubuntu-latestfallback.Production branch (
master). Only workflow present is codeql.yml.🤖 Generated with Claude Code