docs(traces): imported traces stay local; fix the docstrings that said otherwise - #28
Merged
Merged
Conversation
…d otherwise The UtcTimestamp docstring in traces/models.py claimed imported-trace timestamps "are copied into the bundle verbatim by ... from_agent_trace". False: evalshift traces import writes them to .evalshift/runs/<id>/traces.jsonl, read only by evaluate, report.json and diff/inspect/replay case. from_agent_trace has no production caller; bundle.py only calls from_tool_trace, fed by the replay's own tool-call traces. Fixed that docstring and the from_agent_trace docstring and module docstring in hosted/trace_events.py to say so. Comments/docstrings only, no behaviour change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UtcTimestamp's docstring insrc/evalshift_cli/traces/models.pyclaimed imported-trace timestamps "are copied into the bundle verbatim by ...from_agent_trace". That's false:evalshift traces importwrites traces to.evalshift/runs/<id>/traces.jsonl, read only byevaluate,report.jsonanddiff/inspect/replay case.from_agent_tracehas no production caller —hosted/bundle.pyonly callsfrom_tool_trace, fed by the replay's own tool-call traces.from_agent_tracefunction docstring and the module docstring insrc/evalshift_cli/hosted/trace_events.py, to say what actually happens.9fa58ab).Test plan
git grep -n from_agent_trace/from_tool_traceundersrc/to confirmfrom_agent_tracehas no production callermake ci(ruff check, ruff format --check, mypy --strict, pytest w/ coverage floor) — fully green, 2447 passed, 94.50% coverage🤖 Generated with Claude Code