Fix EC key matching and ServerKeyPairValidator for non-IGTF certs#126
Open
DmitryLitvintsev wants to merge 1 commit into
Open
Fix EC key matching and ServerKeyPairValidator for non-IGTF certs#126DmitryLitvintsev wants to merge 1 commit into
DmitryLitvintsev wants to merge 1 commit into
Conversation
CertificateHelpers: normalize EC/ECDSA algorithm names in checkKeysMatching - Handle both directions of EC/ECDSA algorithm name mismatch (modern bcprov-jdk18on returns 'EC' for private keys; some cert implementations return 'ECDSA' for public keys) - Always run signature-based verification for EC key pairs (previously skipped when pubKey.getAlgorithm() == 'EC') - Use SHA256withECDSA instead of deprecated SHA1withECDSA issue: eu-emi#125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CertificateHelpers: normalize EC/ECDSA algorithm names in checkKeysMatching
issue: #125