Skip to content

Added all compiling tests from the test directory - #697

Merged
kottnad merged 10 commits into
masterfrom
Adding_test
Sep 15, 2026
Merged

kottnad merged 10 commits into
masterfrom
Adding_test

Conversation

@mtaillefumier

Copy link
Copy Markdown
Contributor
  • Added all tests from the tests directory that compile
  • Removed Makefile.in
  • Remove variable conflict between tmlqcd and one of the tests

@kostrzewa

Copy link
Copy Markdown
Member

cscs-ci run default

Comment thread src/bin/CMakeLists.txt Outdated
@mtaillefumier

Copy link
Copy Markdown
Contributor Author

@kostrzewa : is there anything else to do for this PR?

@kostrzewa
kostrzewa requested a review from kottnad September 7, 2026 15:42
@kottnad

kottnad commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@mtaillefumier Could you have a look again at test_lemon.c? This is not compiling.

@mtaillefumier

Copy link
Copy Markdown
Contributor Author

test_lemon.c is broken. It call functions that whose signature differs between the header file and the call. I can resolve the compilations issues but I will not know if the test has any value in its current form.

@kottnad

kottnad commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

I just discussed with @kostrzewa , we decided that in fact the test_lemon should be removed entirely, the missing functions don't exist anymore.

@mtaillefumier

Copy link
Copy Markdown
Contributor Author

there is a header file that needs to be removed as well. I will clean this up.

@kottnad

kottnad commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Thanks, looks good.

@kottnad
kottnad merged commit 78d8647 into master Sep 15, 2026
3 checks passed
@kottnad
kottnad deleted the Adding_test branch September 15, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants