Skip to content

fix: use sized integers in the inclusion list view so it caches as SSZ - #922

Closed
barnabasbusa wants to merge 1 commit into
masterfrom
bbusa/il-view-ssz-types
Closed

barnabasbusa wants to merge 1 commit into
masterfrom
bbusa/il-view-ssz-types

Conversation

@barnabasbusa

Copy link
Copy Markdown
Collaborator

The frontend cache logged page model not ssz compatible: slotinclusionlists () error="type validation failed: Committee.Lists: unsupported type: signed or unsigned integers with unspecified size are not supported in SSZ" and fell back to JSON for the inclusion list view, because SlotInclusionListMember.Lists, SlotInclusionListEntry.Transactions and SlotInclusionListSeenBy.Client used Go's platform-sized int, which SSZ cannot encode even with extended types. They are now uint32 (list and tx indexes, client index); the JSON served to the slot page is unchanged. Checked that SlotInclusionListsView passes ValidateType with the cache's dynssz options and round-trips through SSZ.

@barnabasbusa

Copy link
Copy Markdown
Collaborator Author

Superseded by #915, which makes the same change and also tags the FirstSeen pointers as SSZ optionals.

@barnabasbusa
barnabasbusa deleted the bbusa/il-view-ssz-types branch October 23, 2026 14:05

@redpandabot redpandabot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converts the inclusion-list view's platform-sized int fields (member list indexes, transaction indexes, client index) to uint32 so the frontend cache can marshal the page model as SSZ instead of falling back to JSON. All source values are uint16- or committee/client-table-bounded, so the conversions are lossless and the JSON output is unchanged; the new field shapes match those of other page models that already pass the cache's dynssz ValidateType. Clean change.


Reviewed 1 changed file(s) @ 06e52ffe — no blocking issues found.
"If the user can't use it, it doesn't work." — Susan Dray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant