fix: validate soc address in pushsync and pullsync handlers - #5640
Merged
Merged
Conversation
gacevicljubisa
force-pushed
the
fix/sync-soc-address-validation
branch
from
October 2, 2026 17:11
41d1c4a to
5e34757
Compare
gacevicljubisa
marked this pull request as ready for review
October 2, 2026 17:26
acud
approved these changes
Oct 2, 2026
| // FromValidChunk parses the chunk as a single-owner chunk and verifies that | ||
| // the chunk address is the address of the parsed SOC. Unlike FromChunk, it | ||
| // rejects a correctly signed SOC delivered under any other address. | ||
| func FromValidChunk(ch swarm.Chunk) (*SOC, error) { |
Contributor
There was a problem hiding this comment.
nit: FromChunkValidate(). FromValidChunk almost sounds like you assume the chunk is valid but you still don't know at this point
sbackend123
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds the missing validation at the handlers and at the reserve.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure