feat(puller): add pullsync rate metric - #5552
Open
akrem-chabchoub wants to merge 1 commit into
Open
Conversation
martinconic
approved these changes
Aug 3, 2026
Contributor
|
Please add a description |
acud
approved these changes
Aug 4, 2026
acud
left a comment
acud
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just that you can still see the rate of historical syncing by looking at the metric of synced chunks, there's a label historical that shows you the number of chunks arriving from historical syncing, which is in fact a proxy to this measurement. either way it is fine from my side to expose this metric.
| Name: "max_uint_errors", | ||
| Help: "Total max uint errors.", | ||
| }), | ||
| PullsyncRate: prometheus.NewGaugeFunc(prometheus.GaugeOpts{ |
Member
There was a problem hiding this comment.
Should the name be HistoricalSyncRate, because it doesn't count live syncing?
gacevicljubisa
approved these changes
Aug 5, 2026
janos
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The bee node shrinks its storage radius only when historical syncing has fully stopped (SyncRate() == 0). Until now, we couldn't see that sync rate anywhere, so when the radius didn't decrease, we couldn't tell why, or how close it was to happening.
With this change, we expose that number as
bee_puller_pullsync_rate.Now we can put it on a dashboard and watch the story unfold: the rate is high while we catch up on history → it decays to 0 when syncing finishes → and the moment it hits 0, our radius is allowed to step down. With this metric, we make the previously invisible condition that controls radius decrease visible.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure