Fix: Remove committed private TLS material and auto-generate local test assets - #6
Open
mertcano wants to merge 1 commit into
Open
Fix: Remove committed private TLS material and auto-generate local test assets#6mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
…st assets ### Description This PR addresses a critical secret exposure finding within the `safe-client-gateway` repository by removing hardcoded cryptographic assets and automating their secure generation for local development. **Vulnerabilities & Security Defects Remediated:** * **Secrets and Configuration Management (`db_config/test/server.key`, `db_config/test/server.crt`):** A complete private RSA key and its corresponding certificate were previously committed to version control. Both of these artifacts have been completely removed from the repository. * **Safe Asset Generation (`scripts/generate-test-tls.sh`, `test/global-setup.ts`):** Added a reproducible shell script (`generate-test-tls.sh`) that generates short-lived, localhost-only test TLS assets using OpenSSL, enforcing strict owner-only permissions (`chmod 0600`) on the private key. The Jest global setup routine has been updated to automatically provision these files on a fresh checkout if they do not already exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical secret exposure finding within the
safe-client-gatewayrepository by removing hardcoded cryptographic assets and automating their secure generation for local development.Vulnerabilities & Security Defects Remediated:
db_config/test/server.key,db_config/test/server.crt): A complete private RSA key and its corresponding certificate were previously committed to version control. Both of these artifacts have been completely removed from the repository.scripts/generate-test-tls.sh,test/global-setup.ts): Added a reproducible shell script (generate-test-tls.sh) that generates short-lived, localhost-only test TLS assets using OpenSSL, enforcing strict owner-only permissions (chmod 0600) on the private key. The Jest global setup routine has been updated to automatically provision these files on a fresh checkout if they do not already exist.Summary
Changes